WL#15051 Refactor old functionality.

Post push fix. Keep NDBXFRM1 header byte order safe.

NDBXFRM1 file header and trailer fields are written with native byte
order. When reading file from system with opposite byte order the fields
that are sensitive to byte order are adjusted.

WL#15051 added a new field m_encrypt_krm_key_count in header, but did
not handle byte order on read.

Added toggle if needed for the field and also added static asserts to
remind developer when adding fields to header or trailer in future.

Change-Id: I2ee1f73a5004598fea94567112f5d103cb8a17c5

Author: zmur

storage/ndb/src/common/util/ndb_ndbxfrm1.cpp

@@ -969,6 +969,9 @@ int ndb_ndbxfrm1::trailer::fixed_trailer::toggle_endian()
     RETURN(-1);
   toggle_endian64(&m_flags);
   toggle_endian64(&m_data_size);
+  static_assert(sizeof(ndb_ndbxfrm1::trailer::fixed_trailer) == 56,
+   "Remember update ndb_ndbxfrm1::trailer::fixed_trailer::toggle_endian() when "
+   "adding new fields.");
   return 0;
 }
 
@@ -1023,6 +1026,10 @@ int ndb_ndbxfrm1::header::fixed_header::toggle_endian()
   toggle_endian32(&m_encrypt_krm_keying_material_count);
   toggle_endian32(&m_encrypt_key_data_unit_size);
   toggle_endian32(&m_encrypt_krm_keying_material_position_in_octets);
+  toggle_endian32(&m_encrypt_krm_key_count);
+  static_assert(sizeof(ndb_ndbxfrm1::header::fixed_header) == 160,
+   "Remember update ndb_ndbxfrm1::header::fixed_header::toggle_endian() when "
+   "adding new fields.");
   return 0;
 }