Bug#33800633 startChangeNeighbour problem

Revert of original patch.

Testing with debug binaries has revealed problems with
hitting several different assert related to handling of the
TrpId queue mechanism.

Likely cause is that get_trp() seems to deliver the
same TrpId to two different (assist_send-threads), one
where the TrpId is delivered through the neighbour priority
mechaninsm, and another where it is delivered as a non-neighbour.

If this happens it breaks the protection mechanisms if the
transporter buffers, where only a single threads is assumed to
operate on the same TrpId.

Root cause may be that the patch now being reverted called
insert_trp() on transporters having data to sent as part of
startChangeNeighbourNode() - making it a non-neighbour
TrpId awaiting sends.

However, the later call to setNeighbourNode() may reinstantiate
the same NodeId as a neighbour again. Thus the same TrpId
coulde be returned both as a non-neighbour as a neighbour and
be operated upon on two different threads.

Change-Id: Icada4600e008d551e97af2b31abd070f5e4ac68a

Author: Ole John Aske

storage/ndb/src/kernel/vm/mt.cpp

@@ -2049,21 +2049,16 @@ class thr_send_threads {
     NdbMutex_Unlock(m_send_threads[send_instance].send_thread_mutex);
   }
   void startChangeNeighbourNode() {
-    for (Uint32 i = 0; i < MAX_NTRANSPORTERS; i++) {
-      m_trp_state[i].m_neighbour_trp = false;
-    }
     for (Uint32 i = 0; i < globalData.ndbMtSendThreads; i++) {
       NdbMutex_Lock(m_send_threads[i].send_thread_mutex);
-      for (Uint32 j = 0; j < m_send_threads[i].m_num_neighbour_trps; j++) {
-        const TrpId trp_id = m_send_threads[i].m_neighbour_trps[j];
-        if (m_trp_state[trp_id].m_data_available > 0) {
-          // Was a neighbour with pending sends, add to send-queue.
-          insert_trp(m_send_threads[i].m_neighbour_trps[j], &m_send_threads[i]);
-        }
+      for (Uint32 j = 0; j < MAX_NEIGHBOURS; j++) {
         m_send_threads[i].m_neighbour_trps[j] = 0;
       }
       m_send_threads[i].m_num_neighbour_trps = 0;
     }
+    for (Uint32 i = 0; i < MAX_NTRANSPORTERS; i++) {
+      m_trp_state[i].m_neighbour_trp = false;
+    }
   }
   void setNeighbourNode(NodeId nodeId) {
     TrpId trpId[MAX_NODE_GROUP_TRANSPORTERS];