Skip to content

Commit 7e21c20

Browse files
committed
Bug#33985693: Missing dependency on ICU from server unit tests
There is no explicit dependency from the server_unittest_library target to the ICU libraries, so linking of server unit tests fails when building without modules that pull in the dependency implicitly. For example: cmake -DWITH_ICU=system -DWITH_MYSQLX=OFF /path/to/src make Fixed by making the dependency explicit where it's needed. Change-Id: I9ebcceba1f6632014d8d30d1e724e94b404fda9b
1 parent 440d8c3 commit 7e21c20

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2148,6 +2148,7 @@ IF(NOT WITHOUT_SERVER AND WITH_UNIT_TESTS)
21482148
sql_main
21492149
${MYSQLD_STATIC_PLUGIN_LIBS}
21502150
minchassis
2151+
${ICU_LIBRARIES}
21512152
# Import some core symbols. Other symbols needed by the unit test
21522153
# executables are pulled in transitively by symbol dependencies.
21532154
#
@@ -2182,6 +2183,7 @@ IF(NOT WITHOUT_SERVER AND WITH_UNIT_TESTS)
21822183
TARGET_LINK_LIBRARIES(server_unittest_library perfschema)
21832184
TARGET_LINK_LIBRARIES(server_unittest_library sql_main)
21842185
TARGET_LINK_LIBRARIES(server_unittest_library minchassis)
2186+
TARGET_LINK_LIBRARIES(server_unittest_library ${ICU_LIBRARIES})
21852187
ENDIF()
21862188
ENDIF()
21872189

0 commit comments

Comments
 (0)