Bug #31749490 OLD FTS FILES AFTER UPGRADE: ASSERTION FAILURE:

PARS0PARS.CC:736:SYM_NODE->TABLE != NULLPTR

Problem:
If we drop last fulltext index on a table and upgrade the server
from 5.7 to 8.0.
INSERT operation hit an assert.

Analysis:
After dropping last fulltext index, innodb does not drop common aux
tables.
because we still maintain hidden FTS_DOC_ID column &
FTS_DOC_ID_INDEX index in the table.
when we upgrade from 5.7 to 8.0, we do not migrate metadata of fts
common table to server new data dictionary.
Later while inserting into the table, we fetch doc_id from fts
config table.
Since config table is not in server data dictionary, we could not
load innodb metadata object (dict_table_t) for config table and hit
an assert.

Fix:
During upgrade if we keep hidden FTS_DOC_ID column in the table then
migrate metadata of fts common tables to server new data dictionary.

RB: 25080
Reviewed by : Rahul Agarkar <[email protected]>

Author: sachinagarwal1111

mysql-test/suite/innodb/r/upgrade_fts.result

@@ -176,11 +176,21 @@ SELECT lower(name) FROM INFORMATION_SCHEMA.INNODB_TABLES
 WHERE name LIKE '%test%'
   ORDER BY name;
 lower(name)
+test/fts_0000000000000424_being_deleted
+test/fts_0000000000000424_being_deleted_cache
+test/fts_0000000000000424_config
+test/fts_0000000000000424_deleted
+test/fts_0000000000000424_deleted_cache
 test/t1
 SELECT lower(name) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES
 WHERE name LIKE '%test%'
   ORDER BY name;
 lower(name)
+test/fts_0000000000000424_being_deleted
+test/fts_0000000000000424_being_deleted_cache
+test/fts_0000000000000424_config
+test/fts_0000000000000424_deleted
+test/fts_0000000000000424_deleted_cache
 test/t1
 # Check DDL & DML opearations are working
 SELECT * FROM t1;
@@ -245,3 +255,52 @@ DROP TABLE t1;
 # Remove copied files
 # Restart the server
 # restart
+#
+# Bug #31749490 OLD FTS FILES AFTER UPGRADE: ASSERTION FAILURE:
+# PARS0PARS.CC:736:SYM_NODE->TABLE != NULLPTR
+#
+# Stop the running server
+#
+# Copy and unzip the datadir
+#
+# Restart the server with the unzipped datadir
+# restart: --datadir=DATADIR --innodb_page_size=16k
+# Check the contents of INFORMATION_SCHEMA
+SHOW TABLES;
+Tables_in_test
+t1
+SELECT lower(name) FROM INFORMATION_SCHEMA.INNODB_TABLES
+WHERE name LIKE '%test%'
+  ORDER BY name;
+lower(name)
+test/fts_0000000000000424_being_deleted
+test/fts_0000000000000424_being_deleted_cache
+test/fts_0000000000000424_config
+test/fts_0000000000000424_deleted
+test/fts_0000000000000424_deleted_cache
+test/t1
+SELECT lower(name) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES
+WHERE name LIKE '%test%'
+  ORDER BY name;
+lower(name)
+test/fts_0000000000000424_being_deleted
+test/fts_0000000000000424_being_deleted_cache
+test/fts_0000000000000424_config
+test/fts_0000000000000424_deleted
+test/fts_0000000000000424_deleted_cache
+test/t1
+INSERT INTO t1 (val) VALUES ('Upgraded successfully to 8.0 version');
+SELECT * FROM t1;
+id	val
+1	Upgrade mysql database to 8.0 version
+2	Upgraded successfully to 8.0 version
+DELETE FROM t1 WHERE val LIKE 'Upgrade mysql database to 8.0 version';
+SELECT * FROM t1;
+id	val
+2	Upgraded successfully to 8.0 version
+DROP TABLE t1;
+# Cleanup
+# Shutdown server
+# Remove copied files
+# Restart the server
+# restart

mysql-test/suite/innodb/t/upgrade_fts.test

@@ -166,3 +166,56 @@ DROP TABLE t1;
 --echo # Restart the server
 let $restart_parameters =;
 --source include/start_mysqld.inc
+
+--echo #
+--echo # Bug #31749490 OLD FTS FILES AFTER UPGRADE: ASSERTION FAILURE:
+--echo # PARS0PARS.CC:736:SYM_NODE->TABLE != NULLPTR
+--echo #
+
+--echo # Stop the running server
+--source include/shutdown_mysqld.inc
+
+--echo #
+--echo # Copy and unzip the datadir
+--echo #
+
+--copy_file $MYSQLTEST_VARDIR/std_data/data57_drop_fts.zip $MYSQL_TMP_DIR/data57_drop_fts.zip
+--file_exists $MYSQL_TMP_DIR/data57_drop_fts.zip
+--exec unzip -qo $MYSQL_TMP_DIR/data57_drop_fts.zip -d $MYSQL_TMP_DIR
+let $DATADIR1 = $MYSQL_TMP_DIR/data57_drop_fts;
+
+--echo # Restart the server with the unzipped datadir
+--replace_result $DATADIR1 DATADIR
+--let $wait_counter=3000
+--let $restart_parameters = restart: --datadir=$DATADIR1 --innodb_page_size=16k
+--source include/start_mysqld.inc
+
+--echo # Check the contents of INFORMATION_SCHEMA
+SHOW TABLES;
+SELECT lower(name) FROM INFORMATION_SCHEMA.INNODB_TABLES
+  WHERE name LIKE '%test%'
+  ORDER BY name;
+
+SELECT lower(name) FROM INFORMATION_SCHEMA.INNODB_TABLESPACES
+  WHERE name LIKE '%test%'
+  ORDER BY name;
+
+INSERT INTO t1 (val) VALUES ('Upgraded successfully to 8.0 version');
+SELECT * FROM t1;
+
+DELETE FROM t1 WHERE val LIKE 'Upgrade mysql database to 8.0 version';
+SELECT * FROM t1;
+DROP TABLE t1;
+
+--echo # Cleanup
+--echo # Shutdown server
+--source include/shutdown_mysqld.inc
+
+--echo # Remove copied files
+--file_exists $MYSQL_TMP_DIR/data57_drop_fts.zip
+--force-rmdir $MYSQL_TMP_DIR/data57_drop_fts
+--remove_file $MYSQL_TMP_DIR/data57_drop_fts.zip
+
+--echo # Restart the server
+let $restart_parameters =;
+--source include/start_mysqld.inc

storage/innobase/dict/dict0upgrade.cc

@@ -1015,7 +1015,7 @@ bool dd_upgrade_table(THD *thd, const char *db_name, const char *table_name,
     ib_table->autoinc = auto_inc == 0 ? 0 : auto_inc + 1;
   }
 
-  if (dict_table_has_fts_index(ib_table)) {
+  if (dict_table_has_fts_index(ib_table) || added_fts_col) {
     dberr_t err = fts_upgrade_aux_tables(ib_table);
 
     if (err != DB_SUCCESS) {