Bug#35092279 Use of push_warning_printf with severity level SL_ERROR

push_warning / push_warning_printf do not accept ERROR severity in
messages since these are usually logged through other means and are
not presented to the user through the WARNINGS stack. If called thus
then it reduces the severity to WARNING before pushing and logging.

On DEBUG builds, however, it crashes with a failed assert.

This commit changes all ndbcluster handler calls to
push_warning_printf to severity WARNING and, additionally, leverages
the var args of string formats present in the function already.

Change-Id: Iffdb605c7d7b8c7158a451b02df655b561e6e4ad

Author: dtcpatricio

sql/ha_ndbcluster.cc

@@ -1109,7 +1109,7 @@ check_completed_operations_pre_commit(Thd_ndb *thd_ndb, NdbTransaction *trans,
         my_snprintf(msg, sizeof(msg), "Executing extra operations for "
                     "conflict handling hit Ndb error %d '%s'",
                     nonMaskedError.code, nonMaskedError.message);
-        push_warning_printf(current_thd, Sql_condition::SL_ERROR,
+        push_warning_printf(current_thd, Sql_condition::SL_WARNING,
                             ER_EXCEPTIONS_WRITE_ERROR,
                             ER(ER_EXCEPTIONS_WRITE_ERROR), msg);
         /* Slave will stop replication. */