Bug#21696206: ASSERTION `TRANSL->ITEM->FIXED' FAILED IN SELECT_LEX::DELETE_UNUSED_MERGED_COLUMN

It turns out that the standalone PREPARE doesn't call
apply_local_transforms from mysql_prepare_insert, in contrast to
mysql_prepare_delete and mysql_prepare_update.

This has the effect that this resolve phase operation isn't performed when
a standalone prepared insert is performed. Now, at PS execution time, the code
in Sql_cmd_insert::mysql_insert does call apply_local_transforms - for the
first time.  The fact that it is the first call implies this method's call to
fix_prepare_information hasn't been called before.

This again means that the value of st_select_lex::first_execution == true when
we first enter apply_local_transforms (during EXECUTE).

Now, apply_local_transforms tests on this flag in this stanza:

  if (derived_table_count &&
      first_execution &&
      !(thd->lex->context_analysis_only & CONTEXT_ANALYSIS_ONLY_VIEW))
    delete_unused_merged_columns(&top_join_list);

Since first_execution is true, the call to delete_unused_merged_columns is
done.  This is not supposed to have happened, the unused item is no longer
fixed, and the ASSERT happens. Lifting the ASSERT doen't help; we crash later
in sql_authorization.cc:2274 instead.

Adding the call to apply_local_transforms at the end of
mysql_prepare_insert makes the statement work, since we now do the work of
apply_local_transforms also at prepare time, as for DELETE and UPDATE.

We only do this if mysql_prepare_insert is not called for a INSERT..SELECT
since for those statements, apply_local_transforms *are* called during
prepare already (from st_select_lex_unit::prepare), and calling it can cause
things to break, e.g. one of the tests for WL-5275 in insert.test,
cf. discussion on the bug entry.

This patch also fixes Bug#21696641, so test cases have been added for
both 21696206 and 21696641.

Author: Dag Wanvik

mysql-test/r/insert.result

@@ -761,3 +761,45 @@ INSERT INTO v1 VALUES(3);
 REPLACE INTO v1 VALUES(3);
 DROP VIEW v1;
 DROP TABLE t1;
+#
+# Bug#21696206: ASSERTION `TRANSL->ITEM->FIXED' FAILED IN
+#               SELECT_LEX::DELETE_UNUSED_MERGED_COLUMN
+#
+CREATE TABLE t1 ( pk INT, PRIMARY KEY (pk));
+CREATE TABLE t2 LIKE t1;
+INSERT INTO t1 VALUES (2);
+INSERT INTO t2 VALUES (2);
+CREATE VIEW v1 AS SELECT * FROM t2 AS a
+WHERE a.pk IN ( SELECT pk FROM t1 AS b WHERE b.pk = a.pk );
+CREATE VIEW v2 AS SELECT * FROM t1 AS a
+WHERE a.pk IN ( SELECT pk FROM v1 AS b WHERE b.pk = a.pk );
+PREPARE st1 FROM 'INSERT INTO v2 (pk) VALUES ( 1 )';
+EXECUTE st1;
+SELECT * FROM t1;
+pk
+1
+2
+SELECT * FROM t2;
+pk
+2
+DROP TABLE t1, t2;
+DROP VIEW v1, v2;
+#
+# Bug#21696641: ASSERTION !(WANT_PRIVILEGE & ~(GRANT->WANT_PRIVILEGE |
+#               GRANT->PRIVILEGE))'
+#
+CREATE TABLE t1 (pk INT, PRIMARY KEY (pk));
+INSERT INTO t1 VALUES (1);
+CREATE ALGORITHM = TEMPTABLE VIEW v2 AS
+SELECT * FROM t1 AS a NATURAL JOIN t1 b WHERE pk BETWEEN 1 AND 2;
+CREATE ALGORITHM = UNDEFINED VIEW v1 AS
+SELECT * FROM t1 AS a
+WHERE a.pk IN ( SELECT pk FROM v2 AS b WHERE b.pk = a.pk );
+PREPARE st1 FROM "INSERT INTO v1 (pk) VALUES (2)";
+EXECUTE st1;
+SELECT * FROM t1;
+pk
+1
+2
+DROP VIEW v1, v2;
+DROP TABLE t1;

mysql-test/t/insert.test

@@ -604,3 +604,50 @@ REPLACE INTO v1 VALUES(3);
 
 DROP VIEW v1;
 DROP TABLE t1;
+
+--echo #
+--echo # Bug#21696206: ASSERTION `TRANSL->ITEM->FIXED' FAILED IN
+--echo #               SELECT_LEX::DELETE_UNUSED_MERGED_COLUMN
+--echo #
+CREATE TABLE t1 ( pk INT, PRIMARY KEY (pk));
+CREATE TABLE t2 LIKE t1;
+
+INSERT INTO t1 VALUES (2);
+INSERT INTO t2 VALUES (2);
+
+CREATE VIEW v1 AS SELECT * FROM t2 AS a
+                  WHERE a.pk IN ( SELECT pk FROM t1 AS b WHERE b.pk = a.pk );
+
+CREATE VIEW v2 AS SELECT * FROM t1 AS a
+                  WHERE a.pk IN ( SELECT pk FROM v1 AS b WHERE b.pk = a.pk );
+
+PREPARE st1 FROM 'INSERT INTO v2 (pk) VALUES ( 1 )';
+EXECUTE st1;
+
+SELECT * FROM t1;
+SELECT * FROM t2;
+
+DROP TABLE t1, t2;
+DROP VIEW v1, v2;
+
+--echo #
+--echo # Bug#21696641: ASSERTION !(WANT_PRIVILEGE & ~(GRANT->WANT_PRIVILEGE |
+--echo #               GRANT->PRIVILEGE))'
+--echo #
+CREATE TABLE t1 (pk INT, PRIMARY KEY (pk));
+INSERT INTO t1 VALUES (1);
+
+CREATE ALGORITHM = TEMPTABLE VIEW v2 AS
+   SELECT * FROM t1 AS a NATURAL JOIN t1 b WHERE pk BETWEEN 1 AND 2;
+
+CREATE ALGORITHM = UNDEFINED VIEW v1 AS
+   SELECT * FROM t1 AS a
+   WHERE a.pk IN ( SELECT pk FROM v2 AS b WHERE b.pk = a.pk );
+
+PREPARE st1 FROM "INSERT INTO v1 (pk) VALUES (2)";
+EXECUTE st1;
+
+SELECT * FROM t1;
+
+DROP VIEW v1, v2;
+DROP TABLE t1;

sql/sql_insert.cc

@@ -1424,6 +1424,9 @@ bool Sql_cmd_insert_base::mysql_prepare_insert(THD *thd, TABLE_LIST *table_list,
       DBUG_RETURN(true);
   }
 
+  if (!select_insert && select_lex->apply_local_transforms(thd, false))
+    DBUG_RETURN(true);
+
   DBUG_RETURN(false);
 }