Bug#35865221 PB2 weekly valgrind Warning: invalid file descriptor -1 in syscall close()

zmur · zmur · commit 9a07b6e02bf4 · 2023-10-14T15:34:31.000+02:00
Post push fix. Remove redundant call to socket close.

Change-Id: I4bfc2209e6f976aa5642a3c7fa6f12395e9fdc60
diff --git a/storage/ndb/src/common/transporter/Transporter.cpp b/storage/ndb/src/common/transporter/Transporter.cpp
@@ -318,7 +318,6 @@ bool Transporter::connect_client(NdbSocket &&socket) {
   if (!socket.is_valid()) {
     DBUG_PRINT("error", ("Socket %s is not valid", socket.to_string().c_str()));
     DEBUG_FPRINTF((stderr, "Socket not valid\n"));
-    socket.close();
     DBUG_RETURN(false);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,6 @@ bool Transporter::connect_client(NdbSocket &&socket) {`
`318`	`318`	`if (!socket.is_valid()) {`
`319`	`319`	`DBUG_PRINT("error", ("Socket %s is not valid", socket.to_string().c_str()));`
`320`	`320`	`DEBUG_FPRINTF((stderr, "Socket not valid\n"));`
`321`		`- socket.close();`
`322`	`321`	`DBUG_RETURN(false);`
`323`	`322`	`}`
`324`	`323`