Fix for bug#25487493 "TABLE DEFINITION MARKED AS HIDDEN IN HA_RENAME_TABLE".

There was a mismatch in "hidden" attribute between dd::Table object
for new table version which is passed to handler::rename_table() method
and stored in DD during last phases of ALTER TABLE COPY.

This mismatch was caused by the fact that correct value of this
attribute for the dd::Table object was set too late, after the
call to handler::rename_table(), but before object was stored in DD.

This patch fixes the problem by setting the "hidden" attribute value
before handler::rename_table() is called.

This bug was causing issues only in MySQL Cluster tree, so proper test
coverage for it will be provided there.

Author: Dmitry Lenev

sql/dd/dd_table.cc

@@ -2653,13 +2653,10 @@ bool rename_table(THD *thd,
 
 bool rename_table(THD *thd, const char *from_table_name,
                   dd::Table *to_table_def,
-                  bool mark_as_hidden, bool commit_dd_changes)
+                  bool commit_dd_changes)
 {
   Disable_gtid_state_update_guard disabler(thd);
 
-  // Mark the hidden flag.
-  to_table_def->set_hidden(mark_as_hidden);
-
   if (rename_foreign_keys(from_table_name, to_table_def))
     return true;
 

sql/dd/dd_table.h

@@ -309,7 +309,6 @@ bool rename_table(THD *thd,
   @param  thd                  The dictionary client.
   @param  from_table_name      The table name we are renaming from.
   @param  to_table_def         dd::Table for table after rename.
-  @param  mark_as_hidden       Mark the new table as hidden, if true.
   @param  commit_dd_changes    Indicates whether change to the data
                                dictionary needs to be committed.
 
@@ -326,7 +325,7 @@ bool rename_table(THD *thd,
 */
 bool rename_table(THD *thd, const char *from_table_name,
                   dd::Table *to_table_def,
-                  bool mark_as_hidden, bool commit_dd_changes);
+                  bool commit_dd_changes);
 
 /**
   Rename a view in the data-dictionary.

sql/sql_table.cc

@@ -7700,9 +7700,10 @@ mysql_rename_table(THD *thd, handlerton *base, const char *old_db,
                           old_name, &to_table_def))
     DBUG_RETURN(true);
 
-  // Set schema id and table name.
+  // Set schema id, table name and hidden attribute.
   to_table_def->set_schema_id(to_sch->id());
   to_table_def->set_name(new_name);
+  to_table_def->set_hidden(flags & FN_TO_IS_TMP);
 
   // Get the handler for the table, and issue an error if we cannot load it.
   handler *file= (base == NULL ? 0 :
@@ -7784,8 +7785,7 @@ mysql_rename_table(THD *thd, handlerton *base, const char *old_db,
     supporting atomic DDL. And for engines which can't do atomic DDL in
     either case there are scenarios in which DD and SE get out of sync.
   */
-  if (dd::rename_table(thd, old_name, to_table_def, (flags & FN_TO_IS_TMP),
-                       !(flags & NO_DD_COMMIT)))
+  if (dd::rename_table(thd, old_name, to_table_def, !(flags & NO_DD_COMMIT)))
   {
     /*
       In cases when we are executing atomic DDL it is responsibility of the