WL#9271: Mysqlx authentication of users using SHA256-auth-plugin

Post-push fix: Fix Clang build warnings due to inconsistent
usage of the "override" keyword.

Author: jhauglid

rapid/plugin/x/ngs/include/ngs/client.h

@@ -49,8 +49,8 @@ namespace ngs
            Protocol_monitor_interface &pmon);
     virtual ~Client();
 
-    Mutex &get_session_exit_mutex() { return m_session_exit_mutex; }
-    ngs::shared_ptr<Session_interface> session() { return m_session; }
+    Mutex &get_session_exit_mutex() override { return m_session_exit_mutex; }
+    ngs::shared_ptr<Session_interface> session() override { return m_session; }
 
   public: // impl ngs::Client_interface
     void run(const bool skip_resolve_name) override;

rapid/plugin/x/src/xpl_resultset.h

@@ -36,7 +36,8 @@ class Process_resultset : public ngs::Resultset_interface {
   ngs::Command_delegate &get_callbacks() override {
     return m_callback_delegate;
   }
-  const Info &get_info() const { return m_callback_delegate.get_info(); }
+  const Info &get_info() const override
+  { return m_callback_delegate.get_info(); }
 
  private:
   Callback_command_delegate m_callback_delegate;
@@ -59,7 +60,8 @@ class Collect_resultset : public ngs::Resultset_interface {
     return m_buffering_delegate;
   }
 
-  const Info &get_info() const { return m_buffering_delegate.get_info(); }
+  const Info &get_info() const override
+  { return m_buffering_delegate.get_info(); }
 
   void reset() { m_buffering_delegate.reset(); }
 
@@ -91,7 +93,8 @@ class Streaming_resultset : public ngs::Resultset_interface {
   ngs::Command_delegate &get_callbacks() override {
     return m_streaming_delegate;
   }
-  const Info &get_info() const { return m_streaming_delegate.get_info(); }
+  const Info &get_info() const override
+  { return m_streaming_delegate.get_info(); }
 
  private:
   Streaming_command_delegate m_streaming_delegate;

rapid/plugin/x/src/xpl_session.h

@@ -64,12 +64,12 @@ class Session : public ngs::Session
   virtual ~Session();
 
 public: // impl ngs::Session_interface
-  ngs::Error_code init();
-  virtual void on_auth_success(const ngs::Authentication_interface::Response &response);
-  virtual void on_auth_failure(const ngs::Authentication_interface::Response &response);
+  ngs::Error_code init() override;
+  virtual void on_auth_success(const ngs::Authentication_interface::Response &response) override;
+  virtual void on_auth_failure(const ngs::Authentication_interface::Response &response) override;
 
-  virtual void mark_as_tls_session();
-  virtual bool is_handled_by(const void *handler) const;
+  virtual void mark_as_tls_session() override;
+  virtual bool is_handled_by(const void *handler) const override;
   ngs::Sql_session_interface &data_context() override { return m_sql; }
 
 public:
@@ -87,8 +87,8 @@ class Session : public ngs::Session
                      Common_status_variables::*variable);
 
 private: // reimpl ngs::Session
-  virtual void on_kill();
-  virtual bool handle_ready_message(ngs::Request &command);
+  virtual void on_kill() override;
+  virtual bool handle_ready_message(ngs::Request &command) override;
 
 private:
   Sql_data_context m_sql;

rapid/unittest/gunit/xplugin/sasl_plain_auth_t.cc

@@ -31,7 +31,6 @@ namespace {
 const char *const EMPTY = "";
 const char *const AUTH_DATA = "ALA_MA_KOTA";
 const char *const MECHANISM = "MYSQL41";
-const char *const SALT = "SALT";
 
 AssertionResult assert_responce(
     const char *e1_expr, const char *e2_expr,