Bug#32107056 SEVERAL COMPILE WARNINGS FOR MYSQL CLUSTER ON WINDOWS WITH VS 2019 [#2] [noclose]

zmur · zmur · commit c26a939bde98 · 2020-11-05T18:15:27.000+01:00
storage\ndb\src\kernel\blocks\backup\Backup.cpp(2807,37): warning C4805: '==': unsafe mix of type 'Uint32' and type 'bool' in operation

Change-Id: I0582c4e40bcfc69cdf3288ed84ad3ac62c9e4b80
diff --git a/storage/ndb/src/kernel/blocks/backup/Backup.cpp b/storage/ndb/src/kernel/blocks/backup/Backup.cpp
@@ -2804,11 +2804,11 @@ Backup::execDUMP_STATE_ORD(Signal* signal)
      */
     if (signal->length() == 2)
     {
-      if (signal->theData[1] == true)
+      if (signal->theData[1] == 1)
       {
         c_defaults.m_encryption_required = true;
       }
-      else if (signal->theData[1] == false)
+      else if (signal->theData[1] == 0)
       {
         c_defaults.m_encryption_required = false;
       }

Original file line number	Diff line number	Diff line change
`@@ -2804,11 +2804,11 @@ Backup::execDUMP_STATE_ORD(Signal* signal)`
`2804`	`2804`	`*/`
`2805`	`2805`	`if (signal->length() == 2)`
`2806`	`2806`	`{`
`2807`		`- if (signal->theData[1] == true)`
	`2807`	`+ if (signal->theData[1] == 1)`
`2808`	`2808`	`{`
`2809`	`2809`	`c_defaults.m_encryption_required = true;`
`2810`	`2810`	`}`
`2811`		`- else if (signal->theData[1] == false)`
	`2811`	`+ else if (signal->theData[1] == 0)`
`2812`	`2812`	`{`
`2813`	`2813`	`c_defaults.m_encryption_required = false;`
`2814`	`2814`	`}`