Skip to content

Commit c4c63cc

Browse files
committed
Bug#35731994 too verbose error message if acceptor setup fails
When binding to the sockets fails at startup, router reports: start routing failed: Failed setting up acceptor services: Failed setting up acceptor on '/tmp/router-OOYarI/sockfile': Invalid argument which mentions "failed" 3 times. Change ====== - removed "Failed setting up acceptor services" from the error-msg. Change-Id: Ica47d48dac28bac64bf29f3b5b15726ca9e11681
1 parent 2010aeb commit c4c63cc

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

router/src/routing/src/mysql_routing.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -712,8 +712,8 @@ void MySQLRouting::run(mysql_harness::PluginFuncEnv *env) {
712712
auto res = run_acceptor(env);
713713
if (!res) {
714714
clear_running(env);
715-
throw std::runtime_error(string_format(
716-
"Failed setting up acceptor services: %s", res.error().c_str()));
715+
716+
throw std::runtime_error(res.error());
717717
}
718718
}
719719
}

router/tests/component/test_router_configuration_errors.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,8 @@ static const BrokenConfigParams broken_config_params_unix[]{
438438
{"socket", "/this/path/does/not/exist/socket"},
439439
}),
440440
},
441-
"Failed setting up acceptor services: Failed setting up acceptor on "
442-
"'/this/path/does/not/exist/socket': No such file or directory",
441+
"Failed setting up acceptor on '/this/path/does/not/exist/socket': "
442+
"No such file or directory",
443443
""},
444444
};
445445

0 commit comments

Comments
 (0)