WL#15204 TDE: Generate, store and share Node Master Key

Bug#34417282 No program to inspect secrets file, extract key for manual usage of tools.

Post push fix. Make secretsfile endianness safe.

Although not critical to have secretsfile endian safe since we do not
support copying data node filesystem between system of different
endianness it can be nice if ndb_secretsfile_reader tool can read the
secretesfile from systems with the other endianness.

This change always store the key length in secretsfile using little
endian.

Change-Id: I63a9cf286675e15e8f403028185320c0dbae17ad

Author: zmur

storage/ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp

@@ -25,6 +25,7 @@
 #define NDBCNTR_C
 #include "Ndbcntr.hpp"
 
+#include "config.h" // WORDS_BIGENDIAN
 #include <cstring>
 #include <ndb_limits.h>
 #include <ndb_version.h>
@@ -84,6 +85,7 @@
 #include "../backup/BackupFormat.hpp"
 
 #include <NdbGetRUsage.h>
+#include "util/ndb_ndbxfrm1.h" // ndb_ndbxfrm1::toggle_endian
 #include <EventLogger.hpp>
 
 #define JAM_FILE_ID 458
@@ -6447,8 +6449,13 @@ void Ndbcntr::write_secretsfile(Signal *signal)
   Uint32 cnt=0;
   memcpy(&c_secretsfile.m_data[cnt], "NDBSCRT1", 8);
   cnt += ndb_ceil_div<Uint32>(8, sizeof(Uint32));
+  auto key_len_le = globalData.nodeMasterKeyLength;
+#ifdef WORDS_BIGENDIAN
+  // key length should be stored in little endian
+  ndb_ndbxfrm1::toggle_endian32(&key_len_le);
+#endif
   memcpy(&c_secretsfile.m_data[cnt],
-         &globalData.nodeMasterKeyLength,
+         &key_len_le,
          sizeof(globalData.nodeMasterKeyLength));
   cnt += ndb_ceil_div<Uint32>(sizeof(globalData.nodeMasterKeyLength),sizeof(Uint32));
 
@@ -6553,6 +6560,10 @@ void Ndbcntr::read_secretsfile_data(Signal *signal)
   cnt += sizeof(magic);
   Uint32 key_len;
   memcpy(&key_len, ptr+cnt, sizeof(key_len));
+#ifdef WORDS_BIGENDIAN
+  // key length is always stored in little endian
+  ndb_ndbxfrm1::toggle_endian32(&key_len);
+#endif
   assert(key_len == c_nodeMasterKeyLength);
   cnt += sizeof(key_len);
   memset(globalData.nodeMasterKey, 0, MAX_NODE_MASTER_KEY_LENGTH);

storage/ndb/tools/ndb_secretsfile_reader.cpp

@@ -22,6 +22,7 @@
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA
 */
 
+#include "config.h" // WORDS_BIGENDIAN
 #include "util/require.h"
 #include <stdio.h>
 #include <string.h>
@@ -32,6 +33,7 @@
 #include "util/ndb_opts.h"
 #include "util/ndbxfrm_iterator.h"
 #include "util/ndbxfrm_file.h"
+#include "util/ndb_ndbxfrm1.h" // ndb_ndbxfrm1::toggle_endian
 #include "util/ndb_openssl_evp.h"
 
 using byte = unsigned char;
@@ -179,6 +181,10 @@ int read_secrets_file(const char filename[])
 
   Uint32 key_len;
   memcpy(&key_len, &buffer[8], 4);
+#ifdef WORDS_BIGENDIAN
+  // key length is always stored in little endian
+  ndb_ndbxfrm1::toggle_endian32(&key_len);
+#endif
   if(bytes_available < key_len)
   {
     fprintf(stderr, "Error: Failed to read secrets file, "