Bug#35710179: Mysql server 8.1.0 failed at Item_sum_avg::val_decimal

The problem is missing propagation of item properties for the left-hand
expression of an IN subquery predicate, which causes a window function
to loose its property as a window function, and there is subsequent
failure because the code expects a window function later on.

The fix is to add that propagation.

Change-Id: Iae71684c38727cc6db182b1873ff561c07e35f9d

Author: roylyseng

sql/item_subselect.cc

@@ -2733,6 +2733,7 @@ void Item_in_subselect::update_used_tables() {
   Item_subselect::update_used_tables();
   left_expr->update_used_tables();
   m_used_tables_cache |= left_expr->used_tables();
+  add_accum_properties(left_expr);
 }
 
 /**

sql/sql_optimizer.cc

@@ -594,8 +594,11 @@ bool JOIN::optimize(bool finalize_access_paths) {
     // CreateFramebufferTable->ReplaceMaterializedItems's calls of
     // update_used_tables: loses PROP_WINDOW_FUNCTION needed here in next
     // execution round
-    if (m_windows.elements > 0)
-      for (auto f : *fields) f->update_used_tables();
+    if (m_windows.elements > 0) {
+      for (auto f : *fields) {
+        f->update_used_tables();
+      }
+    }
   }
 
   sort_by_table = get_sort_by_table(order.order, group_list.order,