Bug#35809916 NdbMgmd::close() fails to close the m_event_socket

Ole John Aske · Ole John Aske · commit d6760975a9cf · 2023-09-14T20:35:59.000+02:00
testNodeRestart -n GCPStopFalsePositive hit an assert due to a NdbSocket object still
having an open file descrioptor when it was destructed.

Patch add missing NdbSocket::close() on the m_event_socket member in NdbMgmd::close()

Change-Id: I59601336908e42fddc61ff84a2e9a7732218c06a
diff --git a/storage/ndb/test/include/NdbMgmd.hpp b/storage/ndb/test/include/NdbMgmd.hpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2021, Oracle and/or its affiliates.
+/* Copyright (c) 2008, 2023, Oracle and/or its affiliates.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -85,6 +85,7 @@ class NdbMgmd {
       ndb_mgm_destroy_handle(&m_handle);
       m_handle = NULL;
     }
+    m_event_socket.close();
   }
 
   NdbMgmHandle handle(void) const {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* Copyright (c) 2008, 2021, Oracle and/or its affiliates.`
	`1`	`+/* Copyright (c) 2008, 2023, Oracle and/or its affiliates.`
`2`	`2`
`3`	`3`	`This program is free software; you can redistribute it and/or modify`
`4`	`4`	`it under the terms of the GNU General Public License, version 2.0,`
`@@ -85,6 +85,7 @@ class NdbMgmd {`
`85`	`85`	`ndb_mgm_destroy_handle(&m_handle);`
`86`	`86`	`m_handle = NULL;`
`87`	`87`	`}`
	`88`	`+ m_event_socket.close();`
`88`	`89`	`}`
`89`	`90`
`90`	`91`	`NdbMgmHandle handle(void) const {`