Bug#36804785 `false' in operator at sql/sql_executor.cc

A const item that is part of group by and not found in
select list is not added as a hidden item to the fields
list post the fix for Bug#34951115. This is taken into
consideration while checking for replacements for
expressions involving ROLLUP operation during temp table
creation i.e If a const item is not found the field list,
same item is used as replacement as part of Bug#36444257.
However, that fix only checked for const_item() and not
const_for_execution(). The current bug reported fails
the assertion for items that are not marked const, but
only marked const for execution.
Fix is to now check for const_for_execution() instead
of const_item().

Change-Id: I35c717ec23010c69852623f336adfb77818f5080

Author: Chaithra Gopalareddy

mysql-test/r/olap.result

@@ -2372,3 +2372,10 @@ CREATE TABLE t1(f1 INTEGER);
 SELECT SUM(TAN(0)) OVER() FROM t1 GROUP BY TAN(0) WITH ROLLUP;
 SUM(TAN(0)) OVER()
 DROP TABLE t1;
+#
+# Bug#36804785: `false' in operator at sql/sql_executor.cc
+#
+CREATE TABLE t1(f1 INTEGER);
+SELECT SUM(UTC_DATE()) OVER() FROM t1 GROUP BY UTC_DATE() WITH ROLLUP;
+SUM(UTC_DATE()) OVER()
+DROP TABLE t1;

mysql-test/t/olap.test

@@ -1311,3 +1311,11 @@ DROP TABLE t;
 CREATE TABLE t1(f1 INTEGER);
 SELECT SUM(TAN(0)) OVER() FROM t1 GROUP BY TAN(0) WITH ROLLUP;
 DROP TABLE t1;
+
+--echo #
+--echo # Bug#36804785: `false' in operator at sql/sql_executor.cc
+--echo #
+
+CREATE TABLE t1(f1 INTEGER);
+SELECT SUM(UTC_DATE()) OVER() FROM t1 GROUP BY UTC_DATE() WITH ROLLUP;
+DROP TABLE t1;

sql/sql_executor.cc

@@ -4283,7 +4283,7 @@ static bool replace_embedded_rollup_references_with_tmp_fields(
     // A const item that is part of group by and not found in
     // select list will not be found in "fields" (It's not added
     // as a hidden item).
-    if (unwrap_rollup_group(sub_item)->const_item()) {
+    if (unwrap_rollup_group(sub_item)->const_for_execution()) {
       return {ReplaceResult::REPLACE, sub_item};
     }
     assert(false);