Bug#35828929 ndb_mgm_listen_event() does not support TLS

The public MGMAPI function ndb_mgm_listen_event can not be used for
reading events if management connection uses TLS.

Users should if they need consider to use the binary ndb_logevent API
instead.

Test programs are changed to use the internal
ndb_mgm_listen_event_internal instead to support TLS connections.

Change-Id: I2c1b2bfad5bd62584cb575a2df6bd5e1ce9b3a83

Author: zmur

storage/ndb/include/mgmapi/mgmapi.h

@@ -1170,6 +1170,10 @@ struct ssl_ctx_st;
    *               pushed to fd, level=0 ends list.
    *
    * @return fd    filedescriptor to read events from
+   *
+   * Note, events can not be read using this socket if management handle uses
+   * TLS.  Consider to use the binary logevent interface instead, see below
+   * ndb_mgm_create_logevent_handle and ndb_logevent-functions.
    */
 #ifdef _WIN32
   SOCKET ndb_mgm_listen_event(NdbMgmHandle handle, const int filter[]);

storage/ndb/test/include/NdbMgmd.hpp

@@ -463,8 +463,8 @@ class NdbMgmd {
       0
     };
 
-    m_event_socket = ndb_socket_create_from_native(
-                       ndb_mgm_listen_event(m_handle, filter));
+    m_event_socket =
+      ndb_mgm_listen_event_internal(m_handle, filter, 0, true);
 
     return m_event_socket.is_valid();
   }

storage/ndb/test/ndbapi/testLcp.cpp

@@ -30,7 +30,7 @@
 #include <HugoTransactions.hpp>
 #include <UtilTransactions.hpp>
 #include <signaldata/DumpStateOrd.hpp>
-
+#include "mgmapi_internal.h"
 #include <getarg.h>
 #include <InputStream.hpp>
 
@@ -386,8 +386,8 @@ static int pause_lcp(int error)
 
   int filter[] = { 15, NDB_MGM_EVENT_CATEGORY_INFO, 0 };
 
-  NdbSocket my_fd{ndb_socket_create_from_native(
-                    ndb_mgm_listen_event(g_restarter.handle, filter))};
+  NdbSocket my_fd =
+      ndb_mgm_listen_event_internal(g_restarter.handle, filter, 0, true);
 
   require(my_fd.is_valid());
   require(!g_restarter.insertErrorInAllNodes(error));
@@ -482,8 +482,8 @@ static int continue_lcp(int error)
   NdbSocket my_fd;
 
   if(error){
-    my_fd = ndb_socket_create_from_native(
-              ndb_mgm_listen_event(g_restarter.handle, filter));
+    my_fd =
+      ndb_mgm_listen_event_internal(g_restarter.handle, filter, 0, true);
     require(my_fd.is_valid());
   }
 

storage/ndb/test/ndbapi/testMgm.cpp

@@ -507,8 +507,7 @@ int runTestMgmApiEventTimeout(NDBT_Context* ctx, NDBT_Step* step)
                      1, NDB_MGM_EVENT_CATEGORY_STARTUP,
                      0 };
 
-    NdbSocket my_fd{ndb_socket_create_from_native(
-                      ndb_mgm_listen_event(h, filter))};
+    NdbSocket my_fd = ndb_mgm_listen_event_internal(h, filter, 0, true);
 
     if(!my_fd.is_valid())
     {

storage/ndb/test/ndbapi/test_event.cpp

@@ -6152,8 +6152,8 @@ int runGetLogEventPretty(NDBT_Context* ctx, NDBT_Step* step)
     return NDBT_FAILED;
 
   int filter[] = {15, NDB_MGM_EVENT_CATEGORY_INFO, 0};
-  NdbSocket my_fd{ndb_socket_create_from_native(
-                    ndb_mgm_listen_event(mgmd.handle(), filter))};
+  NdbSocket my_fd =
+      ndb_mgm_listen_event_internal(mgmd.handle(), filter, 0, true);
 
   if(!my_fd.is_valid())
   {