Skip to content

Commit 4b18038

Browse files
committed
Refactor AnnotateRoutes.rewrite_contents and .remove_annotations
1 parent ee88f0f commit 4b18038

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

lib/annotate/annotate_routes.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,12 @@ def remove_annotations(_options={})
3939
existing_text = File.read(routes_file)
4040
content, header_position = strip_annotations(existing_text)
4141
new_content = strip_on_removal(content, header_position)
42-
if rewrite_contents(existing_text, new_content)
42+
43+
# Make sure we end on a trailing newline.
44+
new_content << '' unless new_content.last == ''
45+
new_text = new_content.join("\n")
46+
47+
if rewrite_contents(existing_text, new_text)
4348
puts "Removed annotations from #{routes_file}."
4449
end
4550
end
@@ -152,11 +157,7 @@ def strip_on_removal(content, header_position)
152157
end
153158

154159
# @param [String, Array<String>]
155-
def rewrite_contents(existing_text, new_content)
156-
# Make sure we end on a trailing newline.
157-
new_content << '' unless new_content.last == ''
158-
new_text = new_content.join("\n")
159-
160+
def rewrite_contents(existing_text, new_text)
160161
if existing_text == new_text
161162
puts "#{routes_file} unchanged."
162163
false

0 commit comments

Comments
 (0)