Skip to content

Commit 9f8ba0a

Browse files
authored
Merge pull request swiftlang#33277 from brentdax/stop-pretending
Stop pretending that macOS 11 is macOS 10.16
2 parents 154e566 + 1ac9917 commit 9f8ba0a

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

lib/Driver/DarwinToolChains.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -574,14 +574,6 @@ toolchains::Darwin::addDeploymentTargetArgs(ArgStringList &Arguments,
574574
micro = firstMacARM64e.getSubminor().getValueOr(0);
575575
}
576576

577-
// Temporary hack: adjust macOS version passed to the linker from
578-
// 11 down to 10.16, but only for x86.
579-
if (triple.isX86() && major == 11) {
580-
major = 10;
581-
minor = 16;
582-
micro = 0;
583-
}
584-
585577
break;
586578
case DarwinPlatformKind::IPhoneOS:
587579
case DarwinPlatformKind::IPhoneOSSimulator:

test/Driver/linker.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,22 +123,22 @@
123123
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx10.9 -sdk %S/Inputs/MacOSX10.15.sdk %s 2>&1 | %FileCheck -check-prefix MACOS_UNVERSIONED %s
124124

125125
// Check arm64 macOS first deployment version adjustment.
126-
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx10.15.1 %s 2>&1 | %FileCheck -check-prefix ARM64E_MACOS_LINKER %s
126+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx10.15.1 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
127127

128-
// Check x86 macOS 11 deployment version adjustment.
129-
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix X86_MACOS11_LINKER %s
130-
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix ARM64E_MACOS_LINKER %s
128+
// Check x86 macOS 11 deployment version adjustment is gone.
129+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx10.16 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
130+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target x86_64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
131+
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-macosx11.0 %s 2>&1 | %FileCheck -check-prefix MACOS_11_0 %s
131132

132133
// Check arm64 simulators first deployment version adjustment.
133134
// RUN: %swiftc_driver -sdk "" -driver-print-jobs -target arm64-apple-ios13.0-simulator %s 2>&1 | %FileCheck -check-prefix ARM64_IOS_SIMULATOR_LINKER %s
134135

135136

136137
// MACOS_10_15: -platform_version macos 10.9.0 10.15.0
137138
// MACOS_10_15_4: -platform_version macos 10.9.0 10.15.4
139+
// MACOS_11_0: -platform_version macos 11.0.0
138140
// MACOS_UNVERSIONED: -platform_version macos 10.9.0 0.0.0
139141

140-
// ARM64E_MACOS_LINKER: -platform_version macos 11.0.0
141-
// X86_MACOS11_LINKER: -platform_version macos 10.16.0
142142
// X86_64_WATCHOS_SIM_LINKER: -platform_version watchos-simulator 7.0.0
143143
// ARM64_IOS_SIMULATOR_LINKER: -platform_version ios-simulator 14.0.0
144144

0 commit comments

Comments
 (0)