Merge pull request swiftlang#35364 from zoecarver/cxx/follow-up-35311

zoecarver · web-flow · commit f4436f4c140b · 2021-01-12T11:09:33.000-08:00
[nfc] Add comment describing when there may not be a parent source file.
diff --git a/lib/AST/ASTScopeCreation.cpp b/lib/AST/ASTScopeCreation.cpp
@@ -209,6 +209,8 @@ void ASTScope::
 }
 
 void ASTScope::expandFunctionBody(AbstractFunctionDecl *AFD) {
+  // There is no source file associated with C++ decl contexts, so there will
+  // be no parent source file if AFD is a C++ function.
   if (auto *const SF = AFD->getParentSourceFile())
     SF->getScope().expandFunctionBodyImpl(AFD);
 }

Original file line number	Diff line number	Diff line change
`@@ -209,6 +209,8 @@ void ASTScope::`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`void ASTScope::expandFunctionBody(AbstractFunctionDecl *AFD) {`
	`212`	`+ // There is no source file associated with C++ decl contexts, so there will`
	`213`	`+ // be no parent source file if AFD is a C++ function.`
`212`	`214`	`if (auto *const SF = AFD->getParentSourceFile())`
`213`	`215`	`SF->getScope().expandFunctionBodyImpl(AFD);`
`214`	`216`	`}`