[libSyntax] Fix places in which RawSyntax nodes were created without an arena

Author: ahoppen

lib/Parse/ParseExpr.cpp

@@ -1291,7 +1291,8 @@ Parser::parseExprPostfixSuffix(ParserResult<Expr> Result, bool isExprBasic,
       if (SyntaxContext->isEnabled()) {
         // Add dummy blank argument list to the call expression syntax.
         SyntaxContext->addSyntax(
-            SyntaxFactory::makeBlankFunctionCallArgumentList());
+            SyntaxFactory::makeBlankFunctionCallArgumentList(
+                &SyntaxContext->getArena()));
       }
 
       ParserResult<Expr> closure =
@@ -1583,10 +1584,10 @@ ParserResult<Expr> Parser::parseExprPrimary(Diag<> ID, bool isExprBasic) {
                      : VarDecl::Specifier::Var;
       auto pattern = createBindingFromPattern(loc, name, specifier);
       if (SyntaxContext->isEnabled()) {
-        PatternSyntax PatternNode =
-            SyntaxFactory::makeIdentifierPattern(SyntaxContext->popToken());
-        ExprSyntax ExprNode =
-            SyntaxFactory::makeUnresolvedPatternExpr(PatternNode);
+        PatternSyntax PatternNode = SyntaxFactory::makeIdentifierPattern(
+            SyntaxContext->popToken(), &SyntaxContext->getArena());
+        ExprSyntax ExprNode = SyntaxFactory::makeUnresolvedPatternExpr(
+            PatternNode, &SyntaxContext->getArena());
         SyntaxContext->addSyntax(ExprNode);
       }
       return makeParserResult(new (Context) UnresolvedPatternExpr(pattern));
@@ -1721,7 +1722,8 @@ ParserResult<Expr> Parser::parseExprPrimary(Diag<> ID, bool isExprBasic) {
       if (SyntaxContext->isEnabled()) {
         // Add dummy blank argument list to the call expression syntax.
         SyntaxContext->addSyntax(
-            SyntaxFactory::makeBlankFunctionCallArgumentList());
+            SyntaxFactory::makeBlankFunctionCallArgumentList(
+                &SyntaxContext->getArena()));
       }
 
       ParserResult<Expr> closure =
@@ -2087,7 +2089,8 @@ DeclName Parser::parseUnqualifiedDeclName(bool afterDot,
     SyntaxParsingContext ArgsCtxt(SyntaxContext, SyntaxKind::DeclNameArguments);
     consumeToken(tok::l_paren);
     if (SyntaxContext->isEnabled())
-      SyntaxContext->addSyntax(SyntaxFactory::makeBlankDeclNameArgumentList());
+      SyntaxContext->addSyntax(SyntaxFactory::makeBlankDeclNameArgumentList(
+          &SyntaxContext->getArena()));
     consumeToken(tok::r_paren);
     loc = DeclNameLoc(baseNameLoc);
     SmallVector<Identifier, 2> argumentLabels;

lib/Parse/ParseType.cpp

@@ -438,8 +438,8 @@ ParserResult<TypeRepr> Parser::parseType(Diag<> MessageID,
           .useArguments(TupleTypeNode->getElements())
           .useRightParen(TupleTypeNode->getRightParen());
       } else {
-        Builder
-          .addTupleTypeElement(SyntaxFactory::makeTupleTypeElement(InputNode));
+        Builder.addTupleTypeElement(SyntaxFactory::makeTupleTypeElement(
+            InputNode, /*TrailingComma=*/None, &Context.getSyntaxArena()));
       }
       SyntaxContext->addSyntax(Builder.build());
     }
@@ -719,7 +719,8 @@ Parser::parseTypeSimpleOrComposition(Diag<> MessageID,
 
   if (SyntaxContext->isEnabled() && Status.isSuccess()) {
     auto LastNode = SyntaxFactory::makeCompositionTypeElement(
-        SyntaxContext->popIf<TypeSyntax>().getValue(), None);
+        SyntaxContext->popIf<TypeSyntax>().getValue(), None,
+        &SyntaxContext->getArena());
     SyntaxContext->addSyntax(LastNode);
   }
   SyntaxContext->collectNodesInPlace(SyntaxKind::CompositionTypeElementList);