fix(android): wrong line height rendering on android < 28

farfromrefug · farfromrefug · commit 4276ad649427 · 2024-02-22T16:30:25.000+01:00
diff --git a/plugin/platforms/android/java/com/nativescript/label/NSLabel.java b/plugin/platforms/android/java/com/nativescript/label/NSLabel.java
@@ -196,7 +196,7 @@ public void setLineHeight(int value) {
     @Override
     public void setTypeface(Typeface value) {
         super.setTypeface(value);
-        if (Build.VERSION.SDK_INT < 28 && lineHeight >= 0) {
+        if (Build.VERSION.SDK_INT < 28 && lineHeight > 0) {
             float fontHeight = getPaint().getFontMetrics(null);
             setLineSpacing(lineHeight - fontHeight, 1.0f);
         }

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ public void setLineHeight(int value) {`
`196`	`196`	`@Override`
`197`	`197`	`public void setTypeface(Typeface value) {`
`198`	`198`	`super.setTypeface(value);`
`199`		`- if (Build.VERSION.SDK_INT < 28 && lineHeight >= 0) {`
	`199`	`+ if (Build.VERSION.SDK_INT < 28 && lineHeight > 0) {`
`200`	`200`	`float fontHeight = getPaint().getFontMetrics(null);`
`201`	`201`	`setLineSpacing(lineHeight - fontHeight, 1.0f);`
`202`	`202`	`}`