Skip to content

Commit e779a19

Browse files
committed
fix(bottomnavigationbar): android default height
1 parent ec67a95 commit e779a19

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/bottomnavigationbar/bottomnavigationbar.android.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { state, stateSets } from '@nativescript-community/ui-material-core/android/utils';
2-
import { Color, ImageSource, Utils } from '@nativescript/core';
2+
import { Color, ImageSource, Utils, heightProperty } from '@nativescript/core';
33
import {
44
BottomNavigationBarBase,
55
BottomNavigationTabBase,
@@ -105,6 +105,8 @@ export class BottomNavigationBar extends BottomNavigationBarBase {
105105
_items: BottomNavigationTab[];
106106
reselectListener: OnNavigationItemReselectedListener;
107107
selectListener: OnNavigationItemSelectedListener;
108+
// default height property
109+
height = 56;
108110
createNativeView() {
109111
return new com.google.android.material.bottomnavigation.BottomNavigationView(this._context);
110112
}
@@ -157,7 +159,6 @@ export class BottomNavigationBar extends BottomNavigationBarBase {
157159
[tabsProperty.setNative](tabs: BottomNavigationTab[]) {
158160
this.createTabs(tabs);
159161
}
160-
161162
[titleVisibilityProperty.setNative](titleVisibility: TitleVisibility) {
162163
this.nativeViewProtected.setLabelVisibilityMode(titleVisibility);
163164
}
@@ -255,8 +256,8 @@ export class BottomNavigationTab extends BottomNavigationTabBase {
255256
this.inactiveColor instanceof Color
256257
? this.inactiveColor.android
257258
: this.nativeViewProtected.getIconTintList()
258-
? this.nativeViewProtected.getIconTintList().getColorForState(stateSets.BACKGROUND_DEFAULT_STATE_2, color1)
259-
: 0;
259+
? this.nativeViewProtected.getIconTintList().getColorForState(stateSets.BACKGROUND_DEFAULT_STATE_2, color1)
260+
: 0;
260261
const colorStateList = createColorStateList(color1, color2);
261262
// this.nativeViewProtected.color(colorStateList); // can we set the text color?
262263
this.nativeViewProtected.setIconTintList(colorStateList);
@@ -269,8 +270,8 @@ export class BottomNavigationTab extends BottomNavigationTabBase {
269270
this.activeColor instanceof Color
270271
? this.activeColor.android
271272
: this.nativeViewProtected.getIconTintList()
272-
? this.nativeViewProtected.getIconTintList().getColorForState(stateSets.SELECTED_STATE_SET, color2)
273-
: 0;
273+
? this.nativeViewProtected.getIconTintList().getColorForState(stateSets.SELECTED_STATE_SET, color2)
274+
: 0;
274275
const colorStateList = createColorStateList(color1, color2);
275276
// this.nativeViewProtected.setText(colorStateList); // can we set the text color?
276277
this.nativeViewProtected.setIconTintList(colorStateList);

0 commit comments

Comments
 (0)