Allow chunks of size 65535

Driver used to only accept chunks of size 32767. This was a limitation
on the total chunk size, which includes a 2 byte length header and
body. However, Bolt protocol specification allows chunks with body
of size 65535 (0xFFFF).

This commit fixes the problem by making `ChunkDecoder` accept chunks
of size 65535 + 2.

Author: lutovich

driver/src/main/java/org/neo4j/driver/internal/async/inbound/ChunkDecoder.java

@@ -29,11 +29,12 @@
 
 public class ChunkDecoder extends LengthFieldBasedFrameDecoder
 {
-    private static final int MAX_FRAME_LENGTH = Short.MAX_VALUE;
+    private static final int MAX_FRAME_BODY_LENGTH = 0xFFFF;
     private static final int LENGTH_FIELD_OFFSET = 0;
     private static final int LENGTH_FIELD_LENGTH = 2;
     private static final int LENGTH_ADJUSTMENT = 0;
     private static final int INITIAL_BYTES_TO_STRIP = LENGTH_FIELD_LENGTH;
+    private static final int MAX_FRAME_LENGTH = LENGTH_FIELD_LENGTH + MAX_FRAME_BODY_LENGTH;
 
     private final Logging logging;
     private Logger log;

driver/src/test/java/org/neo4j/driver/internal/async/inbound/ChunkDecoderTest.java

@@ -182,6 +182,22 @@ public void shouldLogNonEmptyChunkOnTraceLevel()
         assertByteBufEquals( wrappedBuffer( bytes ), channel.readInbound() );
     }
 
+    @Test
+    public void shouldDecodeMaxSizeChunk()
+    {
+        byte[] message = new byte[0xFFFF];
+
+        ByteBuf input = buffer();
+        input.writeShort( message.length ); // chunk header
+        input.writeBytes( message ); // chunk body
+
+        assertTrue( channel.writeInbound( input ) );
+        assertTrue( channel.finish() );
+
+        assertEquals( 1, channel.inboundMessages().size() );
+        assertByteBufEquals( wrappedBuffer( message ), channel.readInbound() );
+    }
+
     private static ChunkDecoder newChunkDecoder()
     {
         return new ChunkDecoder( DEV_NULL_LOGGING );