Skip to content

Commit 22693d5

Browse files
author
Zhen Li
committed
Fix failure in Auth test where the encryption is not set following the choice of test platform.
1 parent 3765540 commit 22693d5

File tree

5 files changed

+21
-20
lines changed

5 files changed

+21
-20
lines changed

driver/src/test/java/org/neo4j/driver/v1/stress/AbstractStressTestBase.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,7 @@ void setUp()
9999
System.setProperty( DRIVER_METRICS_ENABLED_KEY, "true" );
100100
logging = new LoggerNameTrackingLogging();
101101

102-
Config.ConfigBuilder builder = Config.builder()
103-
.withLogging( logging )
104-
.withMaxConnectionPoolSize( 100 )
105-
.withConnectionAcquisitionTimeout( 1, MINUTES );
106-
107-
driver = (InternalDriver) GraphDatabase.driver( databaseUri(), authToken(), config( builder ) );
102+
driver = (InternalDriver) GraphDatabase.driver( databaseUri(), authToken(), config() );
108103
System.setProperty( DRIVER_METRICS_ENABLED_KEY, "false" );
109104

110105
ThreadFactory threadFactory = new DaemonThreadFactory( getClass().getSimpleName() + "-worker-" );
@@ -184,7 +179,16 @@ private void runStressTest( Function<C,List<Future<?>>> threadLauncher ) throws
184179

185180
abstract AuthToken authToken();
186181

187-
abstract Config config( Config.ConfigBuilder builder );
182+
abstract Config.ConfigBuilder config( Config.ConfigBuilder builder );
183+
184+
Config config()
185+
{
186+
Config.ConfigBuilder builder = Config.builder()
187+
.withLogging( logging )
188+
.withMaxConnectionPoolSize( 100 )
189+
.withConnectionAcquisitionTimeout( 1, MINUTES );
190+
return config( builder ).build();
191+
}
188192

189193
abstract C createContext();
190194

@@ -232,7 +236,7 @@ private List<BlockingCommand<C>> createBlockingCommands()
232236
commands.add( new BlockingFailingQuery<>( driver ) );
233237
commands.add( new BlockingFailingQueryInTx<>( driver ) );
234238

235-
commands.add( new FailedAuth<>( databaseUri(), logging ) );
239+
commands.add( new FailedAuth<>( databaseUri(), config() ) );
236240

237241
commands.addAll( createTestSpecificBlockingCommands() );
238242

driver/src/test/java/org/neo4j/driver/v1/stress/CausalClusteringStressIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ AuthToken authToken()
6868
}
6969

7070
@Override
71-
Config config( Config.ConfigBuilder builder )
71+
Config.ConfigBuilder config( Config.ConfigBuilder builder )
7272
{
73-
return clusterRule.getDriverConfig( builder );
73+
return clusterRule.config( builder );
7474
}
7575

7676
@Override

driver/src/test/java/org/neo4j/driver/v1/stress/FailedAuth.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import org.neo4j.driver.v1.Config;
2424
import org.neo4j.driver.v1.GraphDatabase;
25-
import org.neo4j.driver.v1.Logging;
2625
import org.neo4j.driver.v1.exceptions.SecurityException;
2726

2827
import static org.hamcrest.Matchers.containsString;
@@ -33,19 +32,17 @@
3332
public class FailedAuth<C extends AbstractContext> implements BlockingCommand<C>
3433
{
3534
private final URI clusterUri;
36-
private final Logging logging;
35+
private final Config config;
3736

38-
public FailedAuth( URI clusterUri, Logging logging )
37+
public FailedAuth( URI clusterUri, Config config )
3938
{
4039
this.clusterUri = clusterUri;
41-
this.logging = logging;
40+
this.config = config;
4241
}
4342

4443
@Override
4544
public void execute( C context )
4645
{
47-
Config config = Config.builder().withLogging( logging ).withoutEncryption().build();
48-
4946
SecurityException e = assertThrows( SecurityException.class,
5047
() -> GraphDatabase.driver( clusterUri, basic( "wrongUsername", "wrongPassword" ), config ) );
5148
assertThat( e.getMessage(), containsString( "authentication failure" ) );

driver/src/test/java/org/neo4j/driver/v1/stress/SingleInstanceStressIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ AuthToken authToken()
5454
}
5555

5656
@Override
57-
Config config( Config.ConfigBuilder builder )
57+
Config.ConfigBuilder config( Config.ConfigBuilder builder )
5858
{
59-
return builder.build();
59+
return builder.withoutEncryption();
6060
}
6161

6262
@Override

driver/src/test/java/org/neo4j/driver/v1/util/cc/LocalOrRemoteClusterExtension.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public AuthToken getAuthToken()
6363
return localClusterExtension.getDefaultAuthToken();
6464
}
6565

66-
public Config getDriverConfig( Config.ConfigBuilder builder )
66+
public Config.ConfigBuilder config( Config.ConfigBuilder builder )
6767
{
6868
if ( remoteClusterExists() )
6969
{
@@ -74,7 +74,7 @@ public Config getDriverConfig( Config.ConfigBuilder builder )
7474
builder.withoutEncryption();
7575
}
7676

77-
return builder.build();
77+
return builder;
7878
}
7979

8080
@Override

0 commit comments

Comments
 (0)