Skip to content

Commit 802a181

Browse files
authored
[client] Do not reconnect to mgm server in case of handler error (#3856)
* Do not reconnect to mgm server in case of handler error Set to nil the flow grpc client to nil * Better error handling
1 parent e9108ff commit 802a181

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

client/internal/netflow/manager.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,14 @@ func (m *Manager) disableFlow() error {
123123

124124
m.logger.Close()
125125

126-
if m.receiverClient != nil {
127-
return m.receiverClient.Close()
126+
if m.receiverClient == nil {
127+
return nil
128+
}
129+
130+
err := m.receiverClient.Close()
131+
m.receiverClient = nil
132+
if err != nil {
133+
return fmt.Errorf("close: %w", err)
128134
}
129135

130136
return nil

management/client/grpc.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,6 @@ func (c *GrpcClient) receiveEvents(stream proto.ManagementService_SyncClient, se
260260

261261
if err := msgHandler(decryptedResp); err != nil {
262262
log.Errorf("failed handling an update message received from Management Service: %v", err.Error())
263-
// hide any grpc error code that is not relevant for management
264-
return fmt.Errorf("msg handler error: %v", err.Error())
265263
}
266264
}
267265
}

0 commit comments

Comments
 (0)