Fix deadlock (#3904)

pappz · web-flow · commit aa07b3b87b26 · 2025-05-30T23:38:02.000+02:00
diff --git a/client/internal/peer/conn.go b/client/internal/peer/conn.go
@@ -691,8 +691,7 @@ func (conn *Conn) evalStatus() ConnStatus {
 }
 
 func (conn *Conn) isConnectedOnAllWay() (connected bool) {
-	conn.mu.Lock()
-	defer conn.mu.Unlock()
+	// would be better to protect this with a mutex, but it could cause deadlock with Close function
 
 	defer func() {
 		if !connected {

Original file line number	Diff line number	Diff line change
`@@ -691,8 +691,7 @@ func (conn *Conn) evalStatus() ConnStatus {`
`691`	`691`	`}`
`692`	`692`
`693`	`693`	`func (conn *Conn) isConnectedOnAllWay() (connected bool) {`
`694`		`- conn.mu.Lock()`
`695`		`- defer conn.mu.Unlock()`
	`694`	`+ // would be better to protect this with a mutex, but it could cause deadlock with Close function`
`696`	`695`
`697`	`696`	`defer func() {`
`698`	`697`	`if !connected {`