[client] Ignore irrelevant route changes to tracked network monitor routes

[lixmal]

Describe your changes

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[Copilot]

Pull Request Overview

This PR fixes a bug by ensuring that irrelevant route changes are ignored for tracked network monitor routes. Key changes include updating the RouteUpdate structure to use a Nexthop type, refining error messages in route monitoring functions, and ensuring proper closure of event channels.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
client/internal/routemanager/systemops/systemops_windows.go	Updates RouteUpdate to use a Nexthop type and adjusts logging to reflect this
client/internal/routemanager/systemops/systemops.go	Introduces Nexthop methods (Equal and String) for enhanced type handling
client/internal/networkmonitor/monitor.go	Adds a defer to close the event channel and adjusts logging for soft interfaces
client/internal/networkmonitor/check_change_windows.go	Modifies error messages for route monitor creation
client/internal/networkmonitor/check_change_bsd.go	Updates error messages for opening the routing socket

Comments suppressed due to low confidence (3)

client/internal/networkmonitor/monitor.go:42

• [nitpick] Consider logging the soft interface name (e.g. route.NextHop.Intf.Name) instead of the entire nexthop to improve clarity, as the isSoftInterface check specifically evaluates the interface name.

log.Debugf("Network monitor: ignoring default route change for next hop with soft interface %s", route.NextHop)

client/internal/networkmonitor/check_change_windows.go:16

• [nitpick] Reinstate a failure indicator in the error message (e.g. 'failed to create route monitor:') to clearly denote an error, which could improve error diagnosis.

return fmt.Errorf("create route monitor: %w", err)

client/internal/networkmonitor/check_change_bsd.go:22

• [nitpick] Include a failure verb (e.g. 'failed to open routing socket:') in the error message to clearly reflect an error condition and aid troubleshooting.

return fmt.Errorf("open routing socket: %v", err)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud