[management] fix a bug with missed extra dns labels for a new peer #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug where extra DNS labels were not set on a new peer during registration.
- Fixes missing assignment of extra DNS labels
- Updates the peer creation logic in the account manager
Comments suppressed due to low confidence (2)
management/server/peer.go:774
- Add unit tests for peer registration to ensure that the ExtraDNSLabels field is correctly set on new peer objects. This will help catch any regressions in future changes.
ExtraDNSLabels: login.ExtraDNSLabels,
management/server/peer.go:774
- Verify that the data type of login.ExtraDNSLabels matches the expected type in the nbpeer.Peer struct. If any transformation is needed due to type differences, apply it to ensure compatibility.
ExtraDNSLabels: login.ExtraDNSLabels,
bcmmbaga
reviewed
May 9, 2025
|
bcmmbaga
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
during a registration of a new peer we miss to add extra dns labels to peer object
Issue ticket number and link
Stack
Checklist