[client] Fix UI new version notifier #3845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the UI new version notifier by refining the update mechanism and ensuring proper log initialization.
- Refactored conditional assignments in version/update.go to improve readability.
- Added debug logging for version fetching in version/update.go.
- Updated client UI (client_ui.go) to initialize logging to console when no log file is provided.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| version/update.go | Uses inline assignment for cleaner conditional logic and adds debug logging. |
| client/ui/client_ui.go | Adds fallback log initialization to console when a log file is not provided. |
hakansa
reviewed
May 19, 2025
hakansa
previously approved these changes
May 19, 2025
Co-authored-by: hakansa <[email protected]>
|
hakansa
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist