Skip to content

Commit c266e91

Browse files
committed
Review comments fixed
1 parent 290f9fd commit c266e91

File tree

5 files changed

+14
-13
lines changed

5 files changed

+14
-13
lines changed

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/console/graph/GraphPanelInteractions.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
import com.neueda.jetbrains.plugin.graphdb.visualization.VisualizationApi;
1313
import com.neueda.jetbrains.plugin.graphdb.visualization.events.EventType;
1414

15+
import java.util.Optional;
16+
1517
public class GraphPanelInteractions {
1618

1719
private final GraphConsoleView graphConsoleView;

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/metadata/actions/MetadataAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ public void actionPerformed(AnActionEvent e) {
3737
DataSourcesComponent dataSourcesComponent = project.getComponent(DataSourcesComponent.class);
3838
Optional<DataSourceApi> dataSource = dataSourcesComponent.getDataSourceContainer().findDataSource(dataSourceUuid);
3939

40-
executeQueryEvent.executeQuery(dataSource.get(), payload);
40+
dataSource.ifPresent(dataSourceApi -> executeQueryEvent.executeQuery(dataSourceApi, payload));
4141
}
4242
}

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/metadata/actions/MetadataActionGroup.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
public class MetadataActionGroup extends ActionGroup {
1313

1414
private final String type;
15-
private final String label;
15+
private final String data;
1616
private final String dataSourceUuid;
1717

18-
public MetadataActionGroup(String type, String label, String dataSourceUuid) {
18+
public MetadataActionGroup(String type, String data, String dataSourceUuid) {
1919
this.type = type;
20-
this.label = label;
20+
this.data = data;
2121
this.dataSourceUuid = dataSourceUuid;
2222
}
2323

@@ -26,15 +26,13 @@ public MetadataActionGroup(String type, String label, String dataSourceUuid) {
2626
public AnAction[] getChildren(@Nullable AnActionEvent e) {
2727
switch (type) {
2828
case RELATIONSHIP_TYPES:
29-
return new AnAction[]{new MetadataRelationshipAction(label, dataSourceUuid, "Query this relationship", "", NEO4J)};
29+
return new AnAction[]{new MetadataRelationshipAction(data, dataSourceUuid, "Query this relationship", "", NEO4J)};
3030
case LABELS:
31-
return new AnAction[]{new MetadataLabelAction(label, dataSourceUuid, "Query this label", "", NEO4J)};
31+
return new AnAction[]{new MetadataLabelAction(data, dataSourceUuid, "Query this label", "", NEO4J)};
3232
case PROPERTY_KEYS:
33-
return new AnAction[]{new MetadataPropertyKeyAction(label, dataSourceUuid, "Query this property", "", NEO4J)};
33+
return new AnAction[]{new MetadataPropertyKeyAction(data, dataSourceUuid, "Query this property", "", NEO4J)};
3434
default:
3535
return new AnAction[]{};
3636
}
3737
}
38-
3938
}
40-

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/tree/ContextMenuService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.tree;
22

33
import com.intellij.ui.treeStructure.PatchedDefaultMutableTreeNode;
4-
import com.neueda.jetbrains.plugin.graphdb.jetbrains.component.datasource.state.impl.DataSourceV1;
4+
import com.neueda.jetbrains.plugin.graphdb.jetbrains.component.datasource.state.DataSourceApi;
55
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.metadata.dto.ContextMenu;
66
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.tree.dto.ValueWithIcon;
77

@@ -71,8 +71,8 @@ private Object extractUserObject(Object dataSourceNode) {
7171
}
7272

7373
private String extractUuid(Object dsUserObject) {
74-
if (dsUserObject instanceof DataSourceV1) {
75-
return ((DataSourceV1) dsUserObject).getUUID();
74+
if (dsUserObject instanceof DataSourceApi) {
75+
return ((DataSourceApi) dsUserObject).getUUID();
7676
}
7777
return null;
7878
}

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/tree/DataSourcesTreeMouseAdapter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.metadata.actions.MetadataActionGroup;
99
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.metadata.dto.ContextMenu;
1010

11+
import javax.swing.*;
1112
import javax.swing.tree.TreePath;
1213
import java.awt.event.MouseAdapter;
1314
import java.awt.event.MouseEvent;
@@ -22,7 +23,7 @@ public class DataSourcesTreeMouseAdapter extends MouseAdapter {
2223

2324
@Override
2425
public void mouseClicked(MouseEvent e) {
25-
if (e.getButton() == MouseEvent.BUTTON3) {
26+
if (SwingUtilities.isRightMouseButton(e)) {
2627
Tree tree = (Tree) e.getComponent();
2728
TreePath pathForLocation = tree.getPathForLocation(e.getX(), e.getY());
2829

0 commit comments

Comments
 (0)