Skip to content

Commit e3ae776

Browse files
committed
Fixes
1 parent ea1bf75 commit e3ae776

File tree

5 files changed

+18
-17
lines changed

5 files changed

+18
-17
lines changed

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/console/params/ParametersPanel.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
import com.intellij.openapi.editor.Document;
1010
import com.intellij.openapi.editor.Editor;
1111
import com.intellij.openapi.editor.EditorFactory;
12-
import com.intellij.openapi.fileEditor.*;
12+
import com.intellij.openapi.fileEditor.FileDocumentManager;
13+
import com.intellij.openapi.fileEditor.FileEditor;
14+
import com.intellij.openapi.fileEditor.FileEditorManager;
15+
import com.intellij.openapi.fileEditor.FileEditorManagerEvent;
16+
import com.intellij.openapi.fileEditor.FileEditorManagerListener;
1317
import com.intellij.openapi.fileEditor.ex.FileEditorManagerEx;
1418
import com.intellij.openapi.fileEditor.impl.EditorTabPresentationUtil;
1519
import com.intellij.openapi.fileEditor.impl.EditorWindow;
@@ -33,7 +37,7 @@
3337
import java.awt.*;
3438

3539
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.console.event.QueryParametersRetrievalErrorEvent.PARAMS_ERROR_COMMON_MSG;
36-
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.truncateString;
40+
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.wrapExceptionInMeaningMessage;
3741

3842
public class ParametersPanel implements ParametersProvider {
3943

@@ -79,7 +83,7 @@ private void initializeUi() {
7983
}
8084
String errorMessage;
8185
if (exception.getMessage() != null) {
82-
errorMessage = String.format("%s: %s", PARAMS_ERROR_COMMON_MSG, truncateString(exception.getMessage(), 120));
86+
errorMessage = String.format("%s: %s", PARAMS_ERROR_COMMON_MSG, wrapExceptionInMeaningMessage(exception));
8387
} else {
8488
errorMessage = PARAMS_ERROR_COMMON_MSG;
8589
}

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/actions/DataSourceAction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import javax.swing.*;
1212
import java.io.IOException;
1313

14-
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.truncateString;
14+
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.wrapExceptionInMeaningMessage;
1515

1616
public class DataSourceAction extends AnAction {
1717

@@ -29,7 +29,7 @@ public void actionPerformed(AnActionEvent e) {
2929
try {
3030
FileUtil.openFile(project, FileUtil.getDataSourceFile(project, dataSource));
3131
} catch (IOException exception) {
32-
Notifier.error("Open editor error", truncateString(exception.getMessage(), 120));
32+
Notifier.error("Open editor error", wrapExceptionInMeaningMessage(exception));
3333
}
3434
}
3535
}

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/interactions/DataSourceDialog.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@
2020
import java.awt.*;
2121

2222
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.getCause;
23-
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.truncateString;
2423
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.wrapExceptionInMeaningMessage;
25-
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.wrapText;
2624

2725
public abstract class DataSourceDialog extends DialogWrapper {
2826
public static final int THICKNESS = 10;

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/ui/datasource/interactions/DataSourceInteractions.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,16 @@
1616
import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.tree.TreeNodeModelApi;
1717
import com.neueda.jetbrains.plugin.graphdb.jetbrains.util.FileUtil;
1818
import com.neueda.jetbrains.plugin.graphdb.jetbrains.util.Notifier;
19+
20+
import javax.swing.tree.DefaultMutableTreeNode;
1921
import java.awt.event.MouseAdapter;
2022
import java.awt.event.MouseEvent;
2123
import java.io.IOException;
2224
import java.util.Arrays;
2325
import java.util.List;
2426
import java.util.stream.Collectors;
25-
import javax.swing.tree.DefaultMutableTreeNode;
2627

27-
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.truncateString;
28+
import static com.neueda.jetbrains.plugin.graphdb.jetbrains.util.ExceptionWrapper.wrapExceptionInMeaningMessage;
2829

2930
public class DataSourceInteractions {
3031

@@ -130,7 +131,7 @@ public void mouseClicked(MouseEvent e) {
130131
try {
131132
FileUtil.openFile(project, FileUtil.getDataSourceFile(project, dataSource));
132133
} catch (IOException exception) {
133-
Notifier.error("Open editor error", truncateString(exception.getMessage(), 120));
134+
Notifier.error("Open editor error", wrapExceptionInMeaningMessage(exception));
134135
}
135136
}
136137
}

ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/util/ExceptionWrapper.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
package com.neueda.jetbrains.plugin.graphdb.jetbrains.util;
22

3-
import org.apache.commons.lang.WordUtils;
4-
53
public class ExceptionWrapper {
64
private final static String NON_THIN_CHARS = "[^iIl1\\.,']";
5+
private final static int SHORT_STRING_LENGTH = 140;
76

87
private static int textWidth(String str) {
98
return str.length() - str.replaceAll(NON_THIN_CHARS, "").length() / 2;
@@ -37,10 +36,6 @@ public static String getCause(Exception exception) {
3736
return exceptionCauses.toString();
3837
}
3938

40-
public static String wrapText(String message) {
41-
return WordUtils.wrap(message, 20);
42-
}
43-
4439
public static String wrapExceptionInMeaningMessage(Exception exception) {
4540
String exceptionMessage = exception.getMessage();
4641
if (exceptionMessage.contains("org.apache.tinkerpop.gremlin.driver.ser.SerializationException")) {
@@ -52,6 +47,9 @@ public static String wrapExceptionInMeaningMessage(Exception exception) {
5247
if (exceptionMessage.contains("org.apache.tinkerpop.gremlin.driver.exception.ConnectionException")) {
5348
return "Database connection failed with gremlin driver connection exception. Please check database configuration.";
5449
}
55-
return truncateString(exception.getMessage(), 120);
50+
if (exceptionMessage.length() > SHORT_STRING_LENGTH) {
51+
return truncateString(exceptionMessage, SHORT_STRING_LENGTH);
52+
}
53+
return exceptionMessage;
5654
}
5755
}

0 commit comments

Comments
 (0)