Skip to content

Commit 11ae0d3

Browse files
authored
Merge pull request #199 from jwilder/jw-errors
Fix error message capitalization
2 parents 0d94c6a + 2b03a4e commit 11ae0d3

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

cmd/docker-gen/main.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,13 @@ func main() {
127127
for _, configFile := range configFiles {
128128
err := loadConfig(configFile)
129129
if err != nil {
130-
log.Fatalf("error loading config %s: %s\n", configFile, err)
130+
log.Fatalf("Error loading config %s: %s\n", configFile, err)
131131
}
132132
}
133133
} else {
134134
w, err := dockergen.ParseWait(wait)
135135
if err != nil {
136-
log.Fatalf("error parsing wait interval: %s\n", err)
136+
log.Fatalf("Error parsing wait interval: %s\n", err)
137137
}
138138
config := dockergen.Config{
139139
Template: flag.Arg(0),
@@ -174,10 +174,10 @@ func main() {
174174
})
175175

176176
if err != nil {
177-
log.Fatalf("error creating generator: %v", err)
177+
log.Fatalf("Error creating generator: %v", err)
178178
}
179179

180180
if err := generator.Generate(); err != nil {
181-
log.Fatalf("error running generate: %v", err)
181+
log.Fatalf("Error running generate: %v", err)
182182
}
183183
}

generator.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func NewGenerator(gc GeneratorConfig) (*generator, error) {
5151

5252
apiVersion, err := client.Version()
5353
if err != nil {
54-
log.Printf("error retrieving docker server version info: %s\n", err)
54+
log.Printf("Error retrieving docker server version info: %s\n", err)
5555
}
5656

5757
// Grab the docker daemon info once and hold onto it
@@ -116,7 +116,7 @@ func (g *generator) generateFromSignals() {
116116
func (g *generator) generateFromContainers() {
117117
containers, err := g.getContainers()
118118
if err != nil {
119-
log.Printf("error listing containers: %s\n", err)
119+
log.Printf("Error listing containers: %s\n", err)
120120
return
121121
}
122122
for _, config := range g.Configs.Config {
@@ -344,7 +344,7 @@ func (g *generator) sendSignalToContainer(config Config) {
344344
func (g *generator) getContainers() ([]*RuntimeContainer, error) {
345345
apiInfo, err := g.Client.Info()
346346
if err != nil {
347-
log.Printf("error retrieving docker server info: %s\n", err)
347+
log.Printf("Error retrieving docker server info: %s\n", err)
348348
} else {
349349
SetServerInfo(apiInfo)
350350
}
@@ -361,7 +361,7 @@ func (g *generator) getContainers() ([]*RuntimeContainer, error) {
361361
for _, apiContainer := range apiContainers {
362362
container, err := g.Client.InspectContainer(apiContainer.ID)
363363
if err != nil {
364-
log.Printf("error inspecting container: %s: %s\n", apiContainer.ID, err)
364+
log.Printf("Error inspecting container: %s: %s\n", apiContainer.ID, err)
365365
continue
366366
}
367367

reflect.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func deepGet(item interface{}, path string) interface{} {
4040
return deepGet(mapValue.Interface(), strings.Join(parts[1:], "."))
4141
}
4242
default:
43-
log.Printf("can't group by %s (value %v, kind %s)\n", path, itemValue, itemValue.Kind())
43+
log.Printf("Can't group by %s (value %v, kind %s)\n", path, itemValue, itemValue.Kind())
4444
}
4545
return nil
4646
}

template.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -500,31 +500,31 @@ func GenerateFile(config Config, containers Context) bool {
500500
os.Remove(dest.Name())
501501
}()
502502
if err != nil {
503-
log.Fatalf("unable to create temp file: %s\n", err)
503+
log.Fatalf("Cnable to create temp file: %s\n", err)
504504
}
505505

506506
if n, err := dest.Write(contents); n != len(contents) || err != nil {
507-
log.Fatalf("failed to write to temp file: wrote %d, exp %d, err=%v", n, len(contents), err)
507+
log.Fatalf("Failed to write to temp file: wrote %d, exp %d, err=%v", n, len(contents), err)
508508
}
509509

510510
oldContents := []byte{}
511511
if fi, err := os.Stat(config.Dest); err == nil {
512512
if err := dest.Chmod(fi.Mode()); err != nil {
513-
log.Fatalf("unable to chmod temp file: %s\n", err)
513+
log.Fatalf("Unable to chmod temp file: %s\n", err)
514514
}
515515
if err := dest.Chown(int(fi.Sys().(*syscall.Stat_t).Uid), int(fi.Sys().(*syscall.Stat_t).Gid)); err != nil {
516-
log.Fatalf("unable to chown temp file: %s\n", err)
516+
log.Fatalf("Unable to chown temp file: %s\n", err)
517517
}
518518
oldContents, err = ioutil.ReadFile(config.Dest)
519519
if err != nil {
520-
log.Fatalf("unable to compare current file contents: %s: %s\n", config.Dest, err)
520+
log.Fatalf("Unable to compare current file contents: %s: %s\n", config.Dest, err)
521521
}
522522
}
523523

524524
if bytes.Compare(oldContents, contents) != 0 {
525525
err = os.Rename(dest.Name(), config.Dest)
526526
if err != nil {
527-
log.Fatalf("unable to create dest file %s: %s\n", config.Dest, err)
527+
log.Fatalf("Unable to create dest file %s: %s\n", config.Dest, err)
528528
}
529529
log.Printf("Generated '%s' from %d containers", config.Dest, len(filteredContainers))
530530
return true
@@ -539,13 +539,13 @@ func GenerateFile(config Config, containers Context) bool {
539539
func executeTemplate(templatePath string, containers Context) []byte {
540540
tmpl, err := newTemplate(filepath.Base(templatePath)).ParseFiles(templatePath)
541541
if err != nil {
542-
log.Fatalf("unable to parse template: %s", err)
542+
log.Fatalf("Unable to parse template: %s", err)
543543
}
544544

545545
buf := new(bytes.Buffer)
546546
err = tmpl.ExecuteTemplate(buf, filepath.Base(templatePath), &containers)
547547
if err != nil {
548-
log.Fatalf("template error: %s\n", err)
548+
log.Fatalf("Template error: %s\n", err)
549549
}
550550
return buf.Bytes()
551551
}

0 commit comments

Comments
 (0)