style: linting with staticcheck

Author: buchdag

cmd/docker-gen/main.go

@@ -6,7 +6,6 @@ import (
 	"log"
 	"os"
 	"path/filepath"
-	"sync"
 
 	"github.com/BurntSushi/toml"
 	docker "github.com/fsouza/go-dockerclient"
@@ -36,8 +35,6 @@ var (
 	tlsKey                string
 	tlsCaCert             string
 	tlsVerify             bool
-	tlsCertPath           string
-	wg                    sync.WaitGroup
 )
 
 func (strings *stringslice) String() string {

internal/dockergen/config.go

@@ -73,7 +73,7 @@ func ParseWait(s string) (*Wait, error) {
 			return nil, err
 		}
 		if max < min {
-			return nil, errors.New("Invalid wait interval: max must be larger than min")
+			return nil, errors.New("invalid wait interval: max must be larger than min")
 		}
 	} else {
 		max = 4 * min

internal/dockergen/docker_client.go

@@ -48,7 +48,7 @@ func parseHost(addr string) (string, string, error) {
 	addr = strings.TrimSpace(addr)
 	switch {
 	case addr == "tcp://":
-		return "", "", fmt.Errorf("Invalid bind address format: %s", addr)
+		return "", "", fmt.Errorf("invalid bind address format: %s", addr)
 	case strings.HasPrefix(addr, "unix://"):
 		proto = "unix"
 		addr = strings.TrimPrefix(addr, "unix://")
@@ -65,15 +65,15 @@ func parseHost(addr string) (string, string, error) {
 		addr = "/var/run/docker.sock"
 	default:
 		if strings.Contains(addr, "://") {
-			return "", "", fmt.Errorf("Invalid bind address protocol: %s", addr)
+			return "", "", fmt.Errorf("invalid bind address protocol: %s", addr)
 		}
 		proto = "tcp"
 	}
 
 	if proto != "unix" && strings.Contains(addr, ":") {
 		hostParts := strings.Split(addr, ":")
 		if len(hostParts) != 2 {
-			return "", "", fmt.Errorf("Invalid bind address format: %s", addr)
+			return "", "", fmt.Errorf("invalid bind address format: %s", addr)
 		}
 		if hostParts[0] != "" {
 			host = hostParts[0]
@@ -84,11 +84,11 @@ func parseHost(addr string) (string, string, error) {
 		if p, err := strconv.Atoi(hostParts[1]); err == nil && p != 0 {
 			port = p
 		} else {
-			return "", "", fmt.Errorf("Invalid bind address format: %s", addr)
+			return "", "", fmt.Errorf("invalid bind address format: %s", addr)
 		}
 
 	} else if proto == "tcp" && !strings.Contains(addr, ":") {
-		return "", "", fmt.Errorf("Invalid bind address format: %s", addr)
+		return "", "", fmt.Errorf("invalid bind address format: %s", addr)
 	} else {
 		host = addr
 	}

internal/dockergen/generator.go

@@ -11,7 +11,7 @@ import (
 	"syscall"
 	"time"
 
-	"github.com/fsouza/go-dockerclient"
+	docker "github.com/fsouza/go-dockerclient"
 )
 
 type generator struct {
@@ -41,12 +41,12 @@ type GeneratorConfig struct {
 func NewGenerator(gc GeneratorConfig) (*generator, error) {
 	endpoint, err := GetEndpoint(gc.Endpoint)
 	if err != nil {
-		return nil, fmt.Errorf("Bad endpoint: %s", err)
+		return nil, fmt.Errorf("bad endpoint: %s", err)
 	}
 
 	client, err := NewDockerClient(endpoint, gc.TLSVerify, gc.TLSCert, gc.TLSCACert, gc.TLSKey)
 	if err != nil {
-		return nil, fmt.Errorf("Unable to create docker client: %s", err)
+		return nil, fmt.Errorf("unable to create docker client: %s", err)
 	}
 
 	apiVersion, err := client.Version()
@@ -191,7 +191,7 @@ func (g *generator) generateFromEvents() {
 			watchers = append(watchers, watcher)
 
 			debouncedChan := newDebounceChannel(watcher, config.Wait)
-			for _ = range debouncedChan {
+			for range debouncedChan {
 				containers, err := g.getContainers()
 				if err != nil {
 					log.Printf("Error listing containers: %s\n", err)
@@ -367,7 +367,8 @@ func (g *generator) getContainers() ([]*RuntimeContainer, error) {
 
 	containers := []*RuntimeContainer{}
 	for _, apiContainer := range apiContainers {
-		container, err := g.Client.InspectContainer(apiContainer.ID)
+		opts := docker.InspectContainerOptions{ID: apiContainer.ID}
+		container, err := g.Client.InspectContainerWithOptions(opts)
 		if err != nil {
 			log.Printf("Error inspecting container: %s: %s\n", apiContainer.ID, err)
 			continue
@@ -465,7 +466,7 @@ func (g *generator) getContainers() ([]*RuntimeContainer, error) {
 
 func newSignalChannel() <-chan os.Signal {
 	sig := make(chan os.Signal, 1)
-	signal.Notify(sig, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT, syscall.SIGKILL)
+	signal.Notify(sig, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
 
 	return sig
 }

internal/dockergen/generator_test.go

@@ -12,7 +12,7 @@ import (
 	"testing"
 	"time"
 
-	"github.com/fsouza/go-dockerclient"
+	docker "github.com/fsouza/go-dockerclient"
 	dockertest "github.com/fsouza/go-dockerclient/testing"
 )
 
@@ -49,7 +49,7 @@ func TestGenerateFromEvents(t *testing.T) {
 	}))
 	server.CustomHandler("/containers/json", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		result := []docker.APIContainers{
-			docker.APIContainers{
+			{
 				ID:      containerID,
 				Image:   "base:latest",
 				Command: "/bin/sh",
@@ -87,7 +87,7 @@ func TestGenerateFromEvents(t *testing.T) {
 			},
 			Image: "0ff407d5a7d9ed36acdf3e75de8cc127afecc9af234d05486be2981cdc01a38d",
 			NetworkSettings: &docker.NetworkSettings{
-				IPAddress:   fmt.Sprintf("10.0.0.10"),
+				IPAddress:   "10.0.0.10",
 				IPPrefixLen: 24,
 				Gateway:     "10.0.0.1",
 				Bridge:      "docker0",
@@ -147,24 +147,24 @@ func TestGenerateFromEvents(t *testing.T) {
 		Endpoint: serverURL,
 		Configs: ConfigFile{
 			[]Config{
-				Config{
+				{
 					Template: tmplFile.Name(),
 					Dest:     destFiles[0].Name(),
 					Watch:    false,
 				},
-				Config{
+				{
 					Template: tmplFile.Name(),
 					Dest:     destFiles[1].Name(),
 					Watch:    true,
 					Wait:     &Wait{0, 0},
 				},
-				Config{
+				{
 					Template: tmplFile.Name(),
 					Dest:     destFiles[2].Name(),
 					Watch:    true,
 					Wait:     &Wait{20 * time.Millisecond, 25 * time.Millisecond},
 				},
-				Config{
+				{
 					Template: tmplFile.Name(),
 					Dest:     destFiles[3].Name(),
 					Watch:    true,

internal/dockergen/reflect_test.go

@@ -13,8 +13,7 @@ func TestDeepGetNoPath(t *testing.T) {
 		t.Fail()
 	}
 
-	var returned RuntimeContainer
-	returned = value.(RuntimeContainer)
+	returned := value.(RuntimeContainer)
 	if !returned.Equals(item) {
 		t.Fail()
 	}

internal/dockergen/template.go

@@ -45,7 +45,7 @@ func getArrayValues(funcName string, entries interface{}) (*reflect.Value, error
 	case reflect.Array, reflect.Slice:
 		break
 	default:
-		return nil, fmt.Errorf("Must pass an array or slice to '%v'; received %v; kind %v", funcName, entries, kind)
+		return nil, fmt.Errorf("must pass an array or slice to '%v'; received %v; kind %v", funcName, entries, kind)
 	}
 	return &entriesVal, nil
 }
@@ -121,7 +121,7 @@ func groupByLabel(entries interface{}, label string) (map[string][]interface{},
 			}
 			return nil, nil
 		}
-		return nil, fmt.Errorf("Must pass an array or slice of RuntimeContainer to 'groupByLabel'; received %v", v)
+		return nil, fmt.Errorf("must pass an array or slice of RuntimeContainer to 'groupByLabel'; received %v", v)
 	}
 	return generalizedGroupBy("groupByLabel", entries, getLabel, func(groups map[string][]interface{}, value interface{}, v interface{}) {
 		groups[value.(string)] = append(groups[value.(string)], v)
@@ -261,7 +261,7 @@ func keys(input interface{}) (interface{}, error) {
 
 	val := reflect.ValueOf(input)
 	if val.Kind() != reflect.Map {
-		return nil, fmt.Errorf("Cannot call keys on a non-map value: %v", input)
+		return nil, fmt.Errorf("cannot call keys on a non-map value: %v", input)
 	}
 
 	vk := val.MapKeys()
@@ -534,7 +534,7 @@ func GenerateFile(config Config, containers Context) bool {
 					log.Fatalf("Unable to create empty destination file: %s\n", err)
 				} else {
 					emptyFile.Close()
-					fi, err = os.Stat(config.Dest)
+					fi, _ = os.Stat(config.Dest)
 				}
 			}
 			if err := dest.Chmod(fi.Mode()); err != nil {
@@ -549,7 +549,7 @@ func GenerateFile(config Config, containers Context) bool {
 			}
 		}
 
-		if bytes.Compare(oldContents, contents) != 0 {
+		if !bytes.Equal(oldContents, contents) {
 			err = os.Rename(dest.Name(), config.Dest)
 			if err != nil {
 				log.Fatalf("Unable to create dest file %s: %s\n", config.Dest, err)