Skip to content

Commit 4d61feb

Browse files
committed
tests: Replace counter increment with channel to avoid data race
1 parent 413a77c commit 4d61feb

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

internal/generator/generator_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ import (
2222
func TestGenerateFromEvents(t *testing.T) {
2323
log.SetOutput(ioutil.Discard)
2424
containerID := "8dfafdbc3a40"
25-
counter := 0
25+
counterCh := make(chan int, 50)
26+
for i := 1; len(counterCh) < cap(counterCh); i++ {
27+
counterCh <- i
28+
}
2629

2730
eventsResponse := `
2831
{"status":"start","id":"8dfafdbc3a40","from":"base:latest","time":1374067924}
@@ -67,7 +70,7 @@ func TestGenerateFromEvents(t *testing.T) {
6770
json.NewEncoder(w).Encode(result)
6871
}))
6972
server.CustomHandler(fmt.Sprintf("/containers/%s/json", containerID), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
70-
counter++
73+
counter := <-counterCh
7174
container := docker.Container{
7275
Name: "docker-gen-test",
7376
ID: containerID,

0 commit comments

Comments
 (0)