Skip to content

Commit ad7451f

Browse files
committed
Remove reflection from TestKeys
Now using an actual template. Most tests should probably do this.
1 parent ef19866 commit ad7451f

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

template_test.go

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"encoding/json"
66
"reflect"
77
"testing"
8+
"text/template"
89
)
910

1011
func TestContains(t *testing.T) {
@@ -27,20 +28,16 @@ func TestKeys(t *testing.T) {
2728
expected: "demo.local",
2829
}
2930

30-
k, err := keys(env)
31-
if err != nil {
32-
t.Fatalf("Error fetching keys: %v", err)
33-
}
34-
vk := reflect.ValueOf(k)
35-
if vk.Kind() == reflect.Invalid {
36-
t.Fatalf("Got invalid kind for keys: %v", vk)
37-
}
31+
const text = "{{range (keys $)}}{{.}}{{end}}"
32+
tmpl := template.Must(newTemplate("keys-test").Parse(text))
3833

39-
if len(env) != vk.Len() {
40-
t.Fatalf("Incorrect key count; expected %s, got %s", len(env), vk.Len())
34+
var b bytes.Buffer
35+
err := tmpl.ExecuteTemplate(&b, "keys-test", env)
36+
if err != nil {
37+
t.Fatalf("Error executing template: %v", err)
4138
}
4239

43-
got := vk.Index(0).Interface()
40+
got := b.String()
4441
if expected != got {
4542
t.Fatalf("Incorrect key found; expected %s, got %s", expected, got)
4643
}

0 commit comments

Comments
 (0)