Skip to content

Commit da60fc2

Browse files
authored
Tweak Molecule tests to account for the current supported platforms (#383)
1 parent 20a910e commit da60fc2

File tree

8 files changed

+28
-37
lines changed

8 files changed

+28
-37
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ ENHANCEMENTS:
2121
* Only run GitHub actions Galaxy CI/CD workflow when a new release is published.
2222
* Specify GitHub actions Ubuntu release.
2323
* Minor GitHub template tweaks, including the creation of a SECURITY doc.
24-
* Update list of supported platforms.
24+
* Add Molecule NGINX OSS tests for Alpine 3.13, remove Molecule tests for Debian stretch, and update list of supported platforms.
2525
* Update Ansible base to `2.10.7`, Ansible Lint to `5.0.5`, Molecule to `3.3.0`, yamllint to `1.26.0` and Docker Python SDK to `4.4.4`.
2626
* Consolidate Molecule testing scenarios to address changes introduced in Ansible Lint `5.*`.
2727
* Override of systemd `Restart` value by using proper `nginx_service_restart` variable.

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ Alpine:
6565
- 3.10
6666
- 3.11
6767
- 3.12
68+
- 3.13
6869
CentOS:
6970
- 7.4+
7071
- 8
7172
Debian:
72-
- stretch
7373
- buster
7474
Red Hat:
7575
- 7.4+
@@ -99,7 +99,6 @@ CentOS:
9999
- 7.4+
100100
- 8
101101
Debian:
102-
- stretch
103102
- buster
104103
FreeBSD:
105104
- 11.2+

meta/main.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ galaxy_info:
2222
- any
2323
- name: Debian
2424
versions:
25-
- stretch
2625
- buster
2726
- name: EL
2827
versions:

molecule/default/converge.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
pre_tasks:
55
- name: Set repo if Alpine
66
set_fact:
7-
version: "=1.19.1-r1"
7+
version: "=1.19.8-r1"
88
when: ansible_facts['os_family'] == "Alpine"
99
- name: Set repo if Debian
1010
set_fact:
11-
version: "=1.19.1-1~{{ ansible_facts['distribution_release'] }}"
11+
version: "=1.19.8-1~{{ ansible_facts['distribution_release'] }}"
1212
when: ansible_facts['os_family'] == "Debian"
1313
- name: Set repo if Red Hat
1414
set_fact:
15-
version: "-1.19.1-1.el{{ ansible_facts['distribution_major_version'] }}.ngx"
15+
version: "-1.19.8-1.el{{ ansible_facts['distribution_major_version'] }}.ngx"
1616
when: ansible_facts['os_family'] == "RedHat"
1717
- name: Enable NGINX @CentOS-AppStream dnf modules
1818
shell:

molecule/default/molecule.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ platforms:
2727
volumes:
2828
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
2929
command: "/sbin/init"
30+
- name: alpine-3.13
31+
image: alpine:3.13
32+
dockerfile: ../common/Dockerfile.j2
33+
privileged: true
34+
volumes:
35+
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
36+
command: "/sbin/init"
3037
- name: centos-7
3138
image: centos:7
3239
dockerfile: ../common/Dockerfile.j2
@@ -41,13 +48,6 @@ platforms:
4148
volumes:
4249
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
4350
command: "/usr/sbin/init"
44-
- name: debian-stretch
45-
image: debian:stretch-slim
46-
dockerfile: ../common/Dockerfile.j2
47-
privileged: true
48-
volumes:
49-
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
50-
command: "/sbin/init"
5151
- name: debian-buster
5252
image: debian:buster-slim
5353
dockerfile: ../common/Dockerfile.j2

molecule/module/molecule.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ platforms:
2727
volumes:
2828
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
2929
command: "/sbin/init"
30+
- name: alpine-3.13
31+
image: alpine:3.13
32+
dockerfile: ../common/Dockerfile.j2
33+
privileged: true
34+
volumes:
35+
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
36+
command: "/sbin/init"
3037
- name: centos-7
3138
image: centos:7
3239
dockerfile: ../common/Dockerfile.j2
@@ -41,13 +48,6 @@ platforms:
4148
volumes:
4249
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
4350
command: "/usr/sbin/init"
44-
- name: debian-stretch
45-
image: debian:stretch-slim
46-
dockerfile: ../common/Dockerfile.j2
47-
privileged: true
48-
volumes:
49-
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
50-
command: "/sbin/init"
5151
- name: debian-buster
5252
image: debian:buster-slim
5353
dockerfile: ../common/Dockerfile.j2

molecule/plus/molecule.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ lint: |
77
ansible-lint --force-color
88
platforms:
99
- name: alpine-3.10
10-
image: python:alpine3.10
10+
image: alpine:3.10
1111
dockerfile: ../common/Dockerfile.j2
1212
privileged: true
1313
volumes:
1414
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
1515
command: "/sbin/init"
1616
- name: alpine-3.11
17-
image: python:alpine3.11
17+
image: alpine:3.11
1818
dockerfile: ../common/Dockerfile.j2
1919
privileged: true
2020
volumes:
@@ -41,13 +41,6 @@ platforms:
4141
volumes:
4242
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
4343
command: "/usr/sbin/init"
44-
- name: debian-stretch
45-
image: debian:stretch-slim
46-
dockerfile: ../common/Dockerfile.j2
47-
privileged: true
48-
volumes:
49-
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
50-
command: "/sbin/init"
5144
- name: debian-buster
5245
image: debian:buster-slim
5346
dockerfile: ../common/Dockerfile.j2

molecule/source/molecule.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,13 @@ platforms:
2727
volumes:
2828
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
2929
command: "/sbin/init"
30+
- name: alpine-3.13
31+
image: alpine:3.13
32+
dockerfile: ../common/Dockerfile.j2
33+
privileged: true
34+
volumes:
35+
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
36+
command: "/sbin/init"
3037
- name: centos-7
3138
image: centos:7
3239
dockerfile: ../common/Dockerfile.j2
@@ -41,13 +48,6 @@ platforms:
4148
volumes:
4249
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
4350
command: "/usr/sbin/init"
44-
- name: debian-stretch
45-
image: debian:stretch-slim
46-
dockerfile: ../common/Dockerfile.j2
47-
privileged: true
48-
volumes:
49-
- "/sys/fs/cgroup:/sys/fs/cgroup:rw"
50-
command: "/sbin/init"
5151
- name: debian-buster
5252
image: debian:buster-slim
5353
dockerfile: ../common/Dockerfile.j2

0 commit comments

Comments
 (0)