Skip to content

Commit b538622

Browse files
committed
Add small feedback
1 parent e28a213 commit b538622

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

apis/v1alpha1/nginxproxy_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ const (
193193
IPv6 IPFamilyType = "ipv6"
194194
)
195195

196-
// RewriteClientIPAddress is a struct that specifies address type and value.
196+
// RewriteClientIPAddress specifies the address type and value for a RewriteClientIP address.
197197
type RewriteClientIPAddress struct {
198198
// Type specifies the type of address.
199199
Type RewriteClientIPAddressType `json:"type"`
@@ -217,7 +217,7 @@ const (
217217
RewriteClientIPHostnameAddressType RewriteClientIPAddressType = "Hostname"
218218
)
219219

220-
// NginxPlusAllowAddress is a struct that specifies address type and value.
220+
// NginxPlusAllowAddress specifies the address type and value for an NginxPlus allow address.
221221
type NginxPlusAllowAddress struct {
222222
// Type specifies the type of address.
223223
Type NginxPlusAllowAddressType `json:"type"`

config/crd/bases/gateway.nginx.org_nginxproxies.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ spec:
9090
description: AllowedAddresses specifies IPAddresses or CIDR blocks
9191
to the allow list for accessing the NGINX Plus API.
9292
items:
93-
description: NginxPlusAllowAddress is a struct that specifies
94-
address type and value.
93+
description: NginxPlusAllowAddress specifies the address type
94+
and value for an NginxPlus allow address.
9595
properties:
9696
type:
9797
description: Type specifies the type of address.
@@ -147,8 +147,8 @@ spec:
147147
Sets NGINX directive set_real_ip_from: https://nginx.org/en/docs/http/ngx_http_realip_module.html#set_real_ip_from
148148
This field is required if mode is set.
149149
items:
150-
description: RewriteClientIPAddress is a struct that specifies
151-
address type and value.
150+
description: RewriteClientIPAddress specifies the address type
151+
and value for a RewriteClientIP address.
152152
properties:
153153
type:
154154
description: Type specifies the type of address.

deploy/crds.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -675,8 +675,8 @@ spec:
675675
description: AllowedAddresses specifies IPAddresses or CIDR blocks
676676
to the allow list for accessing the NGINX Plus API.
677677
items:
678-
description: NginxPlusAllowAddress is a struct that specifies
679-
address type and value.
678+
description: NginxPlusAllowAddress specifies the address type
679+
and value for an NginxPlus allow address.
680680
properties:
681681
type:
682682
description: Type specifies the type of address.
@@ -732,8 +732,8 @@ spec:
732732
Sets NGINX directive set_real_ip_from: https://nginx.org/en/docs/http/ngx_http_realip_module.html#set_real_ip_from
733733
This field is required if mode is set.
734734
items:
735-
description: RewriteClientIPAddress is a struct that specifies
736-
address type and value.
735+
description: RewriteClientIPAddress specifies the address type
736+
and value for a RewriteClientIP address.
737737
properties:
738738
type:
739739
description: Type specifies the type of address.

internal/mode/static/state/dataplane/configuration_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4538,7 +4538,7 @@ func TestBuildNginxPlus(t *testing.T) {
45384538
expNginxPlus: defaultNginxPlus,
45394539
},
45404540
{
4541-
msg: "NginxProxy does not specify Nginx Plus settings",
4541+
msg: "NginxPlus default values are used when NginxProxy doesn't specify NginxPlus settings",
45424542
g: &graph.Graph{
45434543
NginxProxy: &graph.NginxProxy{
45444544
Valid: true,

site/content/reference/api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,7 +1382,7 @@ crit, alert, and emerg messages to be logged. <a href="https://nginx.org/en/docs
13821382
<a href="#gateway.nginx.org/v1alpha1.NginxPlus">NginxPlus</a>)
13831383
</p>
13841384
<p>
1385-
<p>NginxPlusAllowAddress is a struct that specifies address type and value.</p>
1385+
<p>NginxPlusAllowAddress specifies the address type and value for an NginxPlus allow address.</p>
13861386
</p>
13871387
<table class="table table-bordered table-striped">
13881388
<thead>
@@ -1683,7 +1683,7 @@ This field is required if mode is set.</p>
16831683
<a href="#gateway.nginx.org/v1alpha1.RewriteClientIP">RewriteClientIP</a>)
16841684
</p>
16851685
<p>
1686-
<p>RewriteClientIPAddress is a struct that specifies address type and value.</p>
1686+
<p>RewriteClientIPAddress specifies the address type and value for a RewriteClientIP address.</p>
16871687
</p>
16881688
<table class="table table-bordered table-striped">
16891689
<thead>

0 commit comments

Comments
 (0)