Panic if addition is nil

Author: Kate Osborn

internal/mode/static/nginx/config/servers.go

@@ -125,7 +125,7 @@ func createAdditionFileResults(conf dataplane.Configuration) []executeResult {
 
 func createAdditionFileName(addition *dataplane.Addition) string {
 	if addition == nil {
-		return ""
+		panic("addition is nil")
 	}
 
 	return fmt.Sprintf("%s/%s.conf", includesFolder, addition.Identifier)

internal/mode/static/nginx/config/servers_test.go

@@ -2510,29 +2510,14 @@ func TestCreateAdditionFileResults(t *testing.T) {
 }
 
 func TestAdditionFilename(t *testing.T) {
-	tests := []struct {
-		name     string
-		addition *dataplane.Addition
-		expName  string
-	}{
-		{
-			name:     "nil addition",
-			addition: nil,
-			expName:  "",
-		},
-		{
-			name:     "normal addition",
-			addition: &dataplane.Addition{Identifier: "my-addition"},
-			expName:  includesFolder + "/" + "my-addition.conf",
-		},
-	}
+	g := NewWithT(t)
 
-	for _, test := range tests {
-		t.Run(test.name, func(t *testing.T) {
-			g := NewWithT(t)
+	name := createAdditionFileName(&dataplane.Addition{Identifier: "my-addition"})
+	g.Expect(name).To(Equal(includesFolder + "/" + "my-addition.conf"))
 
-			name := createAdditionFileName(test.addition)
-			g.Expect(name).To(Equal(test.expName))
-		})
+	create := func() {
+		_ = createAdditionFileName(nil)
 	}
+
+	g.Expect(create).To(Panic())
 }