More code review

Author: sjberman

apis/v1alpha1/nginxgateway_types.go

@@ -50,13 +50,13 @@ type Logging struct {
 type ControllerLogLevel string
 
 const (
-	// Info level for control plane logging.
+	// ControllerLogLevelInfo is the info level for control plane logging.
 	ControllerLogLevelInfo ControllerLogLevel = "info"
 
-	// Debug level for control plane logging.
+	// ControllerLogLevelDebug is the debug level for control plane logging.
 	ControllerLogLevelDebug ControllerLogLevel = "debug"
 
-	// Error level for control plane logging.
+	// ControllerLogLevelError is the error level for control plane logging.
 	ControllerLogLevelError ControllerLogLevel = "error"
 )
 

cmd/gateway/commands_test.go

@@ -116,6 +116,7 @@ func TestStaticModeCmdFlagValidation(t *testing.T) {
 			name: "valid flags",
 			args: []string{
 				"--gateway=nginx-gateway/nginx",
+				"--config=nginx-gateway-config",
 				"--update-gatewayclass-status=true",
 			},
 			wantErr: false,
@@ -142,6 +143,22 @@ func TestStaticModeCmdFlagValidation(t *testing.T) {
 			expectedErrPrefix: `invalid argument "nginx-gateway" for "--gateway" flag: invalid format; ` +
 				"must be NAMESPACE/NAME",
 		},
+		{
+			name: "config is set to empty string",
+			args: []string{
+				"--config=",
+			},
+			wantErr:           true,
+			expectedErrPrefix: `invalid argument "" for "-c, --config" flag: must be set`,
+		},
+		{
+			name: "config is set to invalid string",
+			args: []string{
+				"--config=!@#$",
+			},
+			wantErr:           true,
+			expectedErrPrefix: `invalid argument "!@#$" for "-c, --config" flag: invalid format`,
+		},
 		{
 			name: "update-gatewayclass-status is set to empty string",
 			args: []string{

deploy/helm-chart/templates/control-config.yaml renamed to deploy/helm-chart/templates/nginxgateway.yaml

@@ -347,7 +347,7 @@ metadata:
 spec:
   controllerName: gateway.nginx.org/nginx-gateway-controller
 ---
-# Source: nginx-kubernetes-gateway/templates/control-config.yaml
+# Source: nginx-kubernetes-gateway/templates/nginxgateway.yaml
 apiVersion: gateway.nginx.org/v1alpha1
 kind: NginxGateway
 metadata:

deploy/manifests/nginx-gateway.yaml

@@ -14,8 +14,9 @@ of the resource is `<release-name>-config`. It is deployed in the same Namespace
 
 The control plane only watches this single instance of the custom resource. If the resource is invalid per the OpenAPI
 schema, the Kubernetes API server will reject the changes. If the resource is deleted or deemed invalid by NGINX
-Kubernetes Gateway, an error Event is created in the `nginx-gateway` Namespace, and the default values will be used by
-the control plane for its configuration.
+Kubernetes Gateway, a warning Event is created in the `nginx-gateway` Namespace, and the default values will be used by
+the control plane for its configuration. Additionally, the control plane updates the status of the resource (if it exists)
+to reflect whether it is valid or not.
 
 ### Spec