Skip to content

Commit ef2c0d1

Browse files
committed
Add review feedback for collector test
1 parent e15a506 commit ef2c0d1

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

internal/mode/static/telemetry/collector_test.go

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,11 @@ var _ = Describe("Collector", Ordered, func() {
352352
ngfAPI.NginxContextHTTPServerLocation: "keepalive_time 100s;\nallow 10.0.0.0/8;\n",
353353
},
354354
},
355-
{Namespace: "test", Name: "sf-3"}: {},
355+
{Namespace: "test", Name: "sf-3"}: {
356+
Snippets: map[ngfAPI.NginxContext]string{
357+
ngfAPI.NginxContextHTTPServer: "auth_delay 10s;",
358+
},
359+
},
356360
},
357361
}
358362

@@ -411,17 +415,17 @@ var _ = Describe("Collector", Ordered, func() {
411415
expData.ClusterPlatform = "kind"
412416

413417
expData.SnippetsFiltersContextDirectives = []string{
418+
"server-auth_delay",
414419
"http-aio",
415420
"location-keepalive_time",
416421
"main-worker_priority",
417-
"server-auth_delay",
418422
"http-client_body_timeout",
419423
"location-allow",
420424
"main-worker_rlimit_nofile",
421425
"server-ignore_invalid_headers",
422426
}
423427
expData.SnippetsFiltersContextDirectivesCount = []int64{
424-
2,
428+
3,
425429
2,
426430
2,
427431
2,
@@ -434,14 +438,7 @@ var _ = Describe("Collector", Ordered, func() {
434438
data, err := dataCollector.Collect(ctx)
435439
Expect(err).ToNot(HaveOccurred())
436440

437-
Expect(data.Data).To(Equal(expData.Data))
438-
Expect(data.NGFResourceCounts).To(Equal(expData.NGFResourceCounts))
439-
Expect(data.ImageSource).To(Equal(expData.ImageSource))
440-
Expect(data.FlagNames).To(Equal(expData.FlagNames))
441-
Expect(data.FlagValues).To(Equal(expData.FlagValues))
442-
Expect(data.NGFReplicaCount).To(Equal(expData.NGFReplicaCount))
443-
Expect(data.SnippetsFiltersContextDirectives).To(Equal(expData.SnippetsFiltersContextDirectives))
444-
Expect(data.SnippetsFiltersContextDirectivesCount).To(Equal(expData.SnippetsFiltersContextDirectivesCount))
441+
Expect(data).To(Equal(expData))
445442
})
446443
})
447444
})

0 commit comments

Comments
 (0)