Run pipeline

Author: bjee19

tests/suite/graceful_recovery_test.go

@@ -65,7 +65,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		return nil
 	}
 
-	//var ngfPodName string
+	// var ngfPodName string
 
 	BeforeEach(func() {
 		// this test is unique in that it will check the entire log of both ngf and nginx containers
@@ -89,7 +89,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		Expect(resourceManager.Apply([]client.Object{&ns})).To(Succeed())
 		Expect(resourceManager.ApplyFromFiles(files, ns.Name)).To(Succeed())
 		Expect(resourceManager.WaitForAppsToBeReady(ns.Name)).To(Succeed())
-		//Expect(resourceManager.WaitForAppsToBeReadyWithPodCount(ns.Name, 2)).To(Succeed())
+		// Expect(resourceManager.WaitForAppsToBeReadyWithPodCount(ns.Name, 2)).To(Succeed())
 
 		nginxPodNames, err := framework.GetReadyNginxPodNames(k8sClient, ns.Name, timeoutConfig.GetTimeout)
 		Expect(err).ToNot(HaveOccurred())
@@ -256,7 +256,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 
 		Expect(resourceManager.ApplyFromFiles(files, ns.Name)).To(Succeed())
 		Expect(resourceManager.WaitForAppsToBeReady(ns.Name)).To(Succeed())
-		//Expect(resourceManager.WaitForAppsToBeReadyWithPodCount(ns.Name, 2)).To(Succeed())
+		// Expect(resourceManager.WaitForAppsToBeReadyWithPodCount(ns.Name, 2)).To(Succeed())
 
 		var nginxPodNames []string
 		var err error
@@ -286,7 +286,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		// When the NGINX process is killed, some errors are expected in the NGF logs while we wait for the
 		// NGINX container to be restarted. Therefore, we don't want to check the NGF logs for errors when the container
 		// we restarted was NGINX.
-		//if containerName != nginxContainerName {
+		// if containerName != nginxContainerName {
 		//	checkNGFContainerLogsForErrors(ngfPodName)
 		//}
 	}
@@ -370,7 +370,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		setUpPortForward(nginxPodName, ns.Name)
 
 		checkNGFFunctionality(teaURL, coffeeURL, ngfPodName, "", files, ns)
-		//if errorLogs := getUnexpectedNginxErrorLogs(ngfPodName, ns.Name); errorLogs != "" {
+		// if errorLogs := getUnexpectedNginxErrorLogs(ngfPodName, ns.Name); errorLogs != "" {
 		//	Skip(fmt.Sprintf("NGINX has unexpected error logs: \n%s", errorLogs))
 		//}
 	}
@@ -384,7 +384,6 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 	}
 
 	It("recovers when nginx container is restarted", func() {
-
 		nginxPodNames, err := framework.GetReadyNginxPodNames(k8sClient, ns.Name, timeoutConfig.GetTimeout)
 		Expect(err).ToNot(HaveOccurred())
 		Expect(nginxPodNames).To(HaveLen(1))
@@ -400,14 +399,18 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		setUpPortForward(nginxPodNames[0], ns.Name)
 
 		checkNGFFunctionality(teaURL, coffeeURL, nginxPodName, nginxContainerName, files, &ns)
-		//if errorLogs := getUnexpectedNginxErrorLogs(nginxPodName, ns.Name); errorLogs != "" {
+		// if errorLogs := getUnexpectedNginxErrorLogs(nginxPodName, ns.Name); errorLogs != "" {
 		//	Skip(fmt.Sprintf("NGINX has unexpected error logs: \n%s", errorLogs))
 		//}
 	})
 
 	It("recovers when NGF Pod is restarted", func() {
-
-		startingNGFPodNames, err := framework.GetReadyNGFPodNames(k8sClient, ngfNamespace, releaseName, timeoutConfig.GetTimeout)
+		startingNGFPodNames, err := framework.GetReadyNGFPodNames(
+			k8sClient,
+			ngfNamespace,
+			releaseName,
+			timeoutConfig.GetTimeout,
+		)
 		Expect(err).ToNot(HaveOccurred())
 		Expect(startingNGFPodNames).To(HaveLen(1))
 
@@ -422,7 +425,12 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		var newNGFPodNames []string
 		Eventually(
 			func() bool {
-				newNGFPodNames, err = framework.GetReadyNGFPodNames(k8sClient, ngfNamespace, releaseName, timeoutConfig.GetStatusTimeout)
+				newNGFPodNames, err = framework.GetReadyNGFPodNames(
+					k8sClient,
+					ngfNamespace,
+					releaseName,
+					timeoutConfig.GetStatusTimeout,
+				)
 				return len(newNGFPodNames) == 1 && err == nil
 			}).
 			WithTimeout(timeoutConfig.CreateTimeout * 2).
@@ -436,7 +444,6 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 		Expect(newNGFPodName).ToNot(Equal(startingNGFPodNames[0]))
 
 		checkNGFFunctionality(teaURL, coffeeURL, newNGFPodName, "", files, &ns)
-
 	})
 
 	It("recovers when drained node is restarted", func() {
@@ -448,7 +455,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
 	})
 })
 
-//func runRecoveryTest(teaURL, coffeeURL, ngfPodName, containerName string, files []string, ns *core.Namespace) {
+// func runRecoveryTest(teaURL, coffeeURL, ngfPodName, containerName string, files []string, ns *core.Namespace) {
 //	var (
 //		err       error
 //		leaseName string

tests/suite/system_suite_test.go

@@ -304,7 +304,7 @@ func getDefaultSetupCfg() setupConfig {
 		chartPath:     localChartPath,
 		gwAPIVersion:  *gatewayAPIVersion,
 		deploy:        true,
-		debugLogLevel: false,
+		debugLogLevel: true,
 	}
 }
 
@@ -321,7 +321,7 @@ var _ = BeforeSuite(func() {
 		"telemetry",          // - running telemetry test (NGF will be deployed as part of the test)
 		"scale",              // - running scale test (this test will deploy its own version)
 		"reconfiguration",    // - running reconfiguration test (test will deploy its own instances)
-		//"graceful-recovery",
+		// "graceful-recovery",
 	}
 	for _, s := range skipSubstrings {
 		if strings.Contains(labelFilter, s) {

tests/suite/telemetry_test.go

@@ -11,8 +11,11 @@ import (
 	"github.com/nginx/nginx-gateway-fabric/tests/framework"
 )
 
-// TELEMETRY_ENDPOINT_INSECURE = true.
 var _ = Describe("Telemetry test with OTel collector", Label("telemetry"), func() {
+	// To run the tracing test, you must build NGF with the following values:
+	// TELEMETRY_ENDPOINT=otel-collector-opentelemetry-collector.collector.svc.cluster.local:4317
+	// TELEMETRY_ENDPOINT_INSECURE = true
+
 	BeforeEach(func() {
 		// Because NGF reports telemetry on start, we need to install the collector first.
 

tests/suite/upgrade_test.go

@@ -49,16 +49,16 @@ var _ = Describe("Upgrade testing", Label("nfr", "upgrade"), func() {
 
 		cfg := setupConfig{
 			releaseName: releaseName,
-			//chartPath:     "oci://ghcr.io/nginx/charts/nginx-gateway-fabric",
+			// chartPath:     "oci://ghcr.io/nginx/charts/nginx-gateway-fabric",
 			gwAPIVersion:  *gatewayAPIPrevVersion,
 			deploy:        true,
 			nfr:           true,
 			debugLogLevel: true,
 		}
 
-		//cfg := getDefaultSetupCfg()
-		//cfg.gwAPIVersion = *gatewayAPIPrevVersion
-		//cfg.nfr = true
+		// cfg := getDefaultSetupCfg()
+		// cfg.gwAPIVersion = *gatewayAPIPrevVersion
+		// cfg.nfr = true
 
 		setup(cfg, "--values", valuesFile)