Add fixme

Kate Osborn · Kate Osborn · commit f71d2967d9c2 · 2024-05-20T14:52:43.000-06:00
diff --git a/internal/mode/static/state/graph/backend_tls_policy.go b/internal/mode/static/state/graph/backend_tls_policy.go
@@ -119,6 +119,7 @@ func validateAncestorMaxCount(backendTLSPolicy *v1alpha3.BackendTLSPolicy, ctlrN
 	ancestorRef := createParentReference(v1.GroupName, kinds.Gateway, client.ObjectKeyFromObject(gateway.Source))
 
 	if ancestorsFull(backendTLSPolicy.Status.Ancestors, ancestorRef, ctlrName) {
+		// FIXME (kate-osborn): https://github.com/nginxinc/nginx-gateway-fabric/issues/1987
 		return errors.New("too many ancestors, cannot attach a new Gateway")
 	}
 
diff --git a/internal/mode/static/state/graph/policies.go b/internal/mode/static/state/graph/policies.go
@@ -102,6 +102,7 @@ func attachPolicyToRoute(policy *Policy, route *L7Route, ctlrName string) {
 
 	curAncestorStatus := policy.Source.GetPolicyStatus().Ancestors
 	if ancestorsFull(curAncestorStatus, ancestor.Ancestor, ctlrName) {
+		// FIXME (kate-osborn): https://github.com/nginxinc/nginx-gateway-fabric/issues/1987
 		return
 	}
 
@@ -136,6 +137,7 @@ func attachPolicyToGateway(
 
 	curAncestorStatus := policy.Source.GetPolicyStatus().Ancestors
 	if ancestorsFull(curAncestorStatus, ancestor.Ancestor, ctlrName) {
+		// FIXME (kate-osborn): https://github.com/nginxinc/nginx-gateway-fabric/issues/1987
 		return
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,7 @@ func validateAncestorMaxCount(backendTLSPolicy *v1alpha3.BackendTLSPolicy, ctlrN`
`119`	`119`	`ancestorRef := createParentReference(v1.GroupName, kinds.Gateway, client.ObjectKeyFromObject(gateway.Source))`
`120`	`120`
`121`	`121`	`if ancestorsFull(backendTLSPolicy.Status.Ancestors, ancestorRef, ctlrName) {`
	`122`	`+ // FIXME (kate-osborn): https://github.com/nginxinc/nginx-gateway-fabric/issues/1987`
`122`	`123`	`return errors.New("too many ancestors, cannot attach a new Gateway")`
`123`	`124`	`}`
`124`	`125`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ func attachPolicyToRoute(policy Policy, route L7Route, ctlrName string) {`
`102`	`102`
`103`	`103`	`curAncestorStatus := policy.Source.GetPolicyStatus().Ancestors`
`104`	`104`	`if ancestorsFull(curAncestorStatus, ancestor.Ancestor, ctlrName) {`
	`105`	`+ // FIXME (kate-osborn): https://github.com/nginxinc/nginx-gateway-fabric/issues/1987`
`105`	`106`	`return`
`106`	`107`	`}`
`107`	`108`
`@@ -136,6 +137,7 @@ func attachPolicyToGateway(`
`136`	`137`
`137`	`138`	`curAncestorStatus := policy.Source.GetPolicyStatus().Ancestors`
`138`	`139`	`if ancestorsFull(curAncestorStatus, ancestor.Ancestor, ctlrName) {`
	`140`	`+ // FIXME (kate-osborn): https://github.com/nginxinc/nginx-gateway-fabric/issues/1987`
`139`	`141`	`return`
`140`	`142`	`}`
`141`	`143`