Skip to content

link version to announcement #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2024
Merged

link version to announcement #136

merged 3 commits into from
Apr 3, 2024

Conversation

JTorreG
Copy link
Collaborator

@JTorreG JTorreG commented Apr 2, 2024

Modifies the Sphinx template to link the v. number under the Unit logo to the release announcement.

This requires that the announcement document follows the unit-{{version}}-released naming pattern.

image

@JTorreG JTorreG self-assigned this Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for nginx-unit ready!

Name Link
🔨 Latest commit 29392b3
🔍 Latest deploy log https://app.netlify.com/sites/nginx-unit/deploys/660d21affc2e7c000850b4ed
😎 Deploy Preview https://deploy-preview-136--nginx-unit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JTorreG
Copy link
Collaborator Author

JTorreG commented Apr 2, 2024

Currently the link is still rendered in white color and no underline.

This can be changed to highlight that it's an actual link

@danielledeleo
Copy link
Contributor

Screenshot 2024-04-02 at 11 25 48 AM

Careful about hard coded font colours. This was black in the light theme before.

@JTorreG
Copy link
Collaborator Author

JTorreG commented Apr 2, 2024

Screenshot 2024-04-02 at 11 25 48 AM Careful about hard coded font colours. This was black in the light theme before.

This might be beyond my level of coding, I will have a look see if I can figure it out

@ac000
Copy link
Member

ac000 commented Apr 2, 2024

I see the same thing as @danielledeleo

@JTorreG
Copy link
Collaborator Author

JTorreG commented Apr 2, 2024

I see the same thing as @danielledeleo
Fixed via CSS

image

image

Copy link
Collaborator

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JTorreG JTorreG merged commit fc288ba into master Apr 3, 2024
@JTorreG JTorreG deleted the version-link-to-announce branch April 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants