Callout: Add named parms and better default handling

Author: nginx-jack

exampleSite/content/test-product/call-out/call-out-param-types.md

@@ -0,0 +1,32 @@
+
+---
+description: Callout - Param types
+title: Callout - Param types
+weight: 100
+---
+
+Hugo supports named an unnamed params.
+Named are more readable.
+The callout shortcode aims to support both, but **not** in the same shortcode instance.
+
+
+## The two callouts below using **unnamed** params
+
+{{<call-out "" "Custom title" "fa fa-check-circle" "true">}}
+This callout uses the icon check-circle. **This should be an inline callout.**
+{{</call-out>}}
+
+{{<call-out "" "Custom title" "fa fa-check-circle" "false">}}
+This callout uses the icon check-circle. **This should be an sideline callout.**
+{{</call-out>}}
+
+## The two callouts below using **named** params
+This should work exactly the same as the two callouts above
+
+{{<call-out title="Custom title" icon="fa fa-check-circle" inline="true">}}
+This callout uses the icon check-circle. **This should be an inline callout.**
+{{</call-out>}}
+
+{{<call-out title="Custom title" icon="fa fa-check-circle" inline="asdas">}}
+This callout uses the icon check-circle. **This should be an sideline callout.**
+{{</call-out>}}

layouts/shortcodes/call-out.html

@@ -1,22 +1,35 @@
-{{ $class := .Get 0 }}
+{{ $class := .Get 0 | default (.Get "class") | default "" }}
+{{ $title := .Get 1 | default (.Get "title") | default "" }}
+{{ $icon := .Get 2 | default (.Get "icon") | default "" }}
+
+{{/*  Handle different versions of booleans  */}}
+{{ $inlineParam := (.Get 3) | default (.Get "inline") | default "false" | lower }}
+{{- /* Validate the parameter strictly */ -}}
+{{ if not (in (slice "true" "false") $inlineParam) }}
+  {{ warnf "The '<call-out>' Shortcode parameter 'inline' must be 'true' or 'false', but got: '%s'. This will now default to 'false'" $inlineParam}}
+{{ end }}
+
+{{ $inline := eq $inlineParam "true" }}
+
 {{ $sideOption := "side-callout" }}
 {{ $inlineOption := "inline-callout" }}
 
-<!-- Add default option for callouts that are "sideline" if one is not provided -->
-{{ if and (not (strings.Contains $class $sideOption)) (not (strings.Contains $class $inlineOption)) }}
-{{ $class = printf "%s %s" $class $sideOption }}
+{{ if $inline }}
+  {{ $class = printf "%s %s" $class $inlineOption }}
+{{ else }}
+  {{ $class = printf "%s %s" $class $sideOption }}
 {{ end }}
 
 <!-- Blockquote element with a class that is the first parameter passed to the shortcode -->
 <blockquote class="{{ $class }}">
    <div>
      <!-- Check if the third parameter (icon class) is provided -->
-     {{ with .Get 2 }}
+     {{ with $icon }}
        <!-- If the icon class is provided, render an <i> element with the given class -->
        <i class="{{ . }}"></i>
      {{ end }}
      <!-- Render the second parameter (title) as a strong element -->
-     <strong>{{ .Get 1 }}</strong><br/>
+     <strong>{{ $title }}</strong><br/>
      <!-- Render the inner content of the shortcode, converting it from Markdown to HTML -->
      {{ .Inner | markdownify }}
    </div>