Fix CodeFactor issue

maca88 · maca88 · commit 000137a3884e · 2020-03-12T21:30:05.000+01:00
diff --git a/src/NHibernate.Test/TestCase.cs b/src/NHibernate.Test/TestCase.cs
@@ -515,17 +515,14 @@ protected static int GetTotalOccurrences(string content, string substring)
 				throw new ArgumentNullException(nameof(substring));
 			}
 
-			int occurrences = 0;
-			for (var index = 0; ; index += substring.Length)
+			int occurrences = 0, index = 0;
+			while ((index = content.IndexOf(substring, index)) >= 0)
 			{
-				index = content.IndexOf(substring, index);
-				if (index == -1)
-				{
-					return occurrences;
-				}
-
 				occurrences++;
+				index += substring.Length;
 			}
+
+			return occurrences;
 		}
 
 		protected struct Substitute<TType> : IDisposable

Original file line number	Diff line number	Diff line change
`@@ -515,17 +515,14 @@ protected static int GetTotalOccurrences(string content, string substring)`
`515`	`515`	`throw new ArgumentNullException(nameof(substring));`
`516`	`516`	`}`
`517`	`517`
`518`		`- int occurrences = 0;`
`519`		`- for (var index = 0; ; index += substring.Length)`
	`518`	`+ int occurrences = 0, index = 0;`
	`519`	`+ while ((index = content.IndexOf(substring, index)) >= 0)`
`520`	`520`	`{`
`521`		`- index = content.IndexOf(substring, index);`
`522`		`- if (index == -1)`
`523`		`- {`
`524`		`- return occurrences;`
`525`		`- }`
`526`		`-`
`527`	`521`	`occurrences++;`
	`522`	`+ index += substring.Length;`
`528`	`523`	`}`
	`524`	`+`
	`525`	`+ return occurrences;`
`529`	`526`	`}`
`530`	`527`
`531`	`528`	`protected struct Substitute<TType> : IDisposable`