NH-4004 - More SqlCe tests fixes.

Author: fredericDelaporte

src/NHibernate.Test/CompositeId/CompositeIdFixture.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections;
+using NHibernate.Dialect;
 using NUnit.Framework;
 
 namespace NHibernate.Test.CompositeId
@@ -29,6 +30,12 @@ protected override string CacheConcurrencyStrategy
 			get { return null; }
 		}
 
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			// Order uses a scalar sub-select formula.
+			return Dialect.SupportsScalarSubSelects;
+		}
+
 		[Test]
 		public void CompositeIds()
 		{

src/NHibernate.Test/Hql/Ast/HqlFixture.cs

@@ -341,4 +341,4 @@ public void UnaryMinusBeforeParenthesesHandledCorrectly()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/Hql/Ast/WithClauseFixture.cs

@@ -163,4 +163,4 @@ public void Cleanup()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/Hql/HQLFunctions.cs

@@ -21,7 +21,15 @@ static HQLFunctions()
 						{"locate", new[] {typeof (SQLiteDialect)}},
 						{"bit_length", new[] {typeof (SQLiteDialect)}},
 						{"extract", new[] {typeof (SQLiteDialect)}},
-						{"nullif", new[] {typeof (Oracle8iDialect)}}
+						{
+							"nullif",
+							new[]
+							{
+								typeof (Oracle8iDialect),
+								// Actually not supported by the db engine. (Well, could likely still be done with a case when override.)
+								typeof (MsSqlCeDialect),
+								typeof (MsSqlCe40Dialect)
+							}}
 					};
 		}
 
@@ -74,9 +82,13 @@ public void AggregateCount()
 			using (ISession s = OpenSession())
 			{
 				// Count in select
-				object result = s.CreateQuery("select count(distinct a.id) from Animal a").UniqueResult();
-				Assert.AreEqual(typeof(long), result.GetType());
-				Assert.AreEqual(2, result);
+				object result;
+				if (TestDialect.SupportsCountDistinct)
+				{
+					result = s.CreateQuery("select count(distinct a.id) from Animal a").UniqueResult();
+					Assert.AreEqual(typeof(long), result.GetType());
+					Assert.AreEqual(2, result);
+				}
 
 				result = s.CreateQuery("select count(*) from Animal").UniqueResult();
 				Assert.AreEqual(typeof(long), result.GetType());
@@ -758,6 +770,17 @@ public void Cast()
 							if (!ex.InnerException.Message.Contains(msgToCheck))
 								throw;
 						}
+						else if (Dialect is MsSqlCeDialect)
+						{
+							var errorCodeProperty = ex.InnerException.GetType().GetProperty("NativeError");
+							if (errorCodeProperty == null ||
+								// 25515 is the error code for "In aggregate and grouping expressions, the SELECT clause can contain only aggregates and grouping expressions."
+								// https://technet.microsoft.com/en-us/library/ms172350(v=sql.110).aspx
+								errorCodeProperty.GetValue(ex.InnerException) as int? != 25515)
+							{
+								throw;
+							}
+						}
 						else
 						{
 							string msgToCheck =
@@ -864,6 +887,7 @@ public void Current_TimeStamp_Offset()
 		public void Extract()
 		{
 			IgnoreIfNotSupported("extract");
+			IgnoreIfNotSupported("current_timestamp");
 
 			// test only the parser and render
 			using (ISession s = OpenSession())
@@ -906,6 +930,9 @@ public void Concat()
 		public void HourMinuteSecond()
 		{
 			IgnoreIfNotSupported("second");
+			IgnoreIfNotSupported("minute");
+			IgnoreIfNotSupported("hour");
+			IgnoreIfNotSupported("current_timestamp");
 			// test only the parser and render
 			using (ISession s = OpenSession())
 			{
@@ -997,6 +1024,7 @@ from MaterialResource mr
 		[Test]
 		public void NH1725()
 		{
+			IgnoreIfNotSupported("iif");
 			// Only to test the parser
 			using (ISession s = OpenSession())
 			{

src/NHibernate.Test/Immutable/EntityWithMutableCollection/AbstractEntityWithOneToManyTest.cs

@@ -1223,7 +1223,23 @@ public virtual void OneToManyCollectionOptimisticLockingWithUpdate()
 			s = OpenSession();
 			t = s.BeginTransaction();
 			c = s.CreateCriteria<Contract>().UniqueResult<Contract>();
-			s.CreateQuery("delete from Party").ExecuteUpdate();
+			// If the entity uses a join mapping, DML queries require temp tables.
+			if (Dialect.SupportsTemporaryTables)
+				s.CreateQuery("delete from Party").ExecuteUpdate();
+			else
+			{
+				// The current join mapping seems a bit invalid or unsupported.
+				// The party_contract join table is optional, but its FK is not-nullable. The test removes the contract
+				// from both parties (explicitly for partyOrig, indirectly by updating cOrig instead of c for newParty),
+				// and it the appears those parties are no more loadable, failing with a "not-null property references a
+				// null or transient value NHibernate.Test.Immutable.EntityWithMutableCollection.Party.Contract".
+				// So we need to "fix" already previously loaded instances before deleting them.
+				partyOrig.Contract = cOrig;
+				newParty.Contract = cOrig;
+				s.Delete(partyOrig);
+				s.Delete(newParty);
+			}
+
 			s.Delete(c);
 			Assert.That(s.CreateCriteria<Contract>().SetProjection(Projections.RowCountInt64()).UniqueResult<long>(), Is.EqualTo(0L));
 			Assert.That(s.CreateCriteria<Party>().SetProjection(Projections.RowCountInt64()).UniqueResult<long>(), Is.EqualTo(0L));

src/NHibernate.Test/Legacy/ABCTest.cs

@@ -39,6 +39,8 @@ public void HigherLevelIndexDefinitionInPropertyTag()
 		[Test]
 		public void Subselect()
 		{
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-select, used by Map formula in B (C1 and C2) mapping");
 			using (ISession s = OpenSession())
 			using (ITransaction t = s.BeginTransaction())
 			{
@@ -78,6 +80,8 @@ public void Subselect()
 		[Test]
 		public void Subclassing()
 		{
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-select, used by Map formula in B (C1 and C2) mapping");
 			ISession s = OpenSession();
 			ITransaction t = s.BeginTransaction();
 			C1 c1 = new C1();

src/NHibernate.Test/Legacy/FooBarTest.cs

@@ -522,11 +522,14 @@ public void Query()
 					Assert.AreEqual(2, list.Count, "component query");
 				}
 
-				list =
-					s.CreateQuery("from foo in class NHibernate.DomainModel.Foo where size(foo.Component.ImportantDates) = 3").List();
-				Assert.AreEqual(2, list.Count, "component query");
-				list = s.CreateQuery("from foo in class Foo where 0 = size(foo.Component.ImportantDates)").List();
-				Assert.AreEqual(0, list.Count, "component query");
+				if (Dialect.SupportsScalarSubSelects)
+				{
+					list =
+						s.CreateQuery("from foo in class NHibernate.DomainModel.Foo where size(foo.Component.ImportantDates) = 3").List();
+					Assert.AreEqual(2, list.Count, "component query");
+					list = s.CreateQuery("from foo in class Foo where 0 = size(foo.Component.ImportantDates)").List();
+					Assert.AreEqual(0, list.Count, "component query");
+				}
 				list = s.CreateQuery("from foo in class Foo where exists elements(foo.Component.ImportantDates)").List();
 				Assert.AreEqual(2, list.Count, "component query");
 				s.CreateQuery("from foo in class Foo where not exists (from bar in class Bar where bar.id = foo.id)").List();
@@ -1095,7 +1098,8 @@ public void QueryCollectionOfValues()
 
 				if (Dialect.SupportsSubSelects)
 				{
-					s.CreateFilter(baz.FooArray, "where size(this.Bytes) > 0").List();
+					if (Dialect.SupportsScalarSubSelects)
+						s.CreateFilter(baz.FooArray, "where size(this.Bytes) > 0").List();
 					s.CreateFilter(baz.FooArray, "where 0 in elements(this.Bytes)").List();
 				}
 				s.Flush();
@@ -2385,7 +2389,7 @@ public void CompositeKeyPathExpressions()
 			hql = "from fum1 in class Fum where fum1.Fo.FumString is not null order by fum1.Fo.FumString";
 			s.CreateQuery(hql).List();
 
-			if (Dialect.SupportsSubSelects)
+			if (Dialect.SupportsScalarSubSelects)
 			{
 				hql = "from fum1 in class Fum where size(fum1.Friends) = 0";
 				s.CreateQuery(hql).List();
@@ -2461,7 +2465,7 @@ public void CollectionsInSelect()
 				s.CreateQuery("select count(*) from Bar as bar where 1 in indices(bar.Baz.FooArray)").List();
 				s.CreateQuery(
 					"select count(*) from Bar as bar where '1' in (from bar.Component.Glarch.ProxyArray g where g.Name='foo')").List();
-				
+
 				// The nex query is wrong and is not present in H3.2:
 				// The SQL result, from Classic parser, is the same of the previous query.
 				// The AST parser has some problem to parse 'from g in bar.Component.Glarch.ProxyArray'
@@ -2472,7 +2476,9 @@ public void CollectionsInSelect()
 
 				// TODO: figure out why this is throwing an ORA-1722 error
 				// probably the conversion ProxyArray.id (to_number ensuring a not null value)
-				if (!(Dialect is Oracle8iDialect))
+				// Indeed, ProxyArray.id is Glarch.tha_key which is a string filled with a Guid. It does
+				// not fail with most engine likely because there are no results thanks to other conditions.
+				if (!(Dialect is Oracle8iDialect) && !(Dialect is MsSqlCeDialect))
 				{
 					s.CreateQuery(
 						"select count(*) from Bar as bar join bar.Component.Glarch.ProxyArray as g where cast(g.id as Int32) in indices(bar.Baz.FooArray)").

src/NHibernate.Test/Legacy/FumTest.cs

@@ -598,7 +598,8 @@ public void CompositeKeyPathExpressions()
 				if (Dialect.SupportsSubSelects)
 				{
 					s.CreateQuery("from fum1 in class Fum where exists elements(fum1.Friends)").List();
-					s.CreateQuery("from fum1 in class Fum where size(fum1.Friends) = 0").List();
+					if (Dialect.SupportsScalarSubSelects)
+						s.CreateQuery("from fum1 in class Fum where size(fum1.Friends) = 0").List();
 				}
 				s.CreateQuery("select elements(fum1.Friends) from fum1 in class Fum").List();
 				s.CreateQuery("from fum1 in class Fum, fr in elements( fum1.Friends )").List();

src/NHibernate.Test/Legacy/MasterDetailTest.cs

@@ -401,7 +401,7 @@ public void MasterDetail()
 			master.AddDetail(d1);
 			master.AddDetail(d2);
 
-			if (Dialect.SupportsSubSelects)
+			if (Dialect.SupportsScalarSubSelects)
 			{
 				string hql = "from d in class NHibernate.DomainModel.Detail, m in class NHibernate.DomainModel.Master " +
 				             "where m = d.Master and m.Outgoing.size = 0 and m.Incoming.size = 0";

src/NHibernate.Test/Legacy/ParentChildTest.cs

@@ -387,7 +387,7 @@ public void CollectionQuery()
 			Assert.AreEqual(1,
 			                s.CreateQuery("select c from c in class ContainerX where 's' = c.ManyToMany[(3+1)/4-1].Name").List().
 			                	Count);
-			if (Dialect.SupportsSubSelects)
+			if (Dialect.SupportsScalarSubSelects)
 			{
 				Assert.AreEqual(1,
 				                s.CreateQuery(

src/NHibernate.Test/Legacy/SQLFunctionsTest.cs

@@ -492,11 +492,14 @@ public void SQLFunctions()
 
 				if (Dialect.SupportsSubSelects && TestDialect.SupportsOperatorSome)
 				{
-					Assert.AreEqual(2,
-									s.CreateQuery(
-										"from s in class Simple where s.Count > ( select min(sim.Count) from sim in class NHibernate.DomainModel.Simple )")
-										.List().Count);
-					t.Commit();
+					if (Dialect.SupportsScalarSubSelects)
+					{
+						Assert.AreEqual(2,
+							s.CreateQuery(
+									"from s in class Simple where s.Count > ( select min(sim.Count) from sim in class NHibernate.DomainModel.Simple )")
+								.List().Count);
+						t.Commit();
+					}
 					t = s.BeginTransaction();
 					Assert.AreEqual(2,
 									s.CreateQuery(

src/NHibernate.Test/Legacy/SQLLoaderTest.cs

@@ -333,8 +333,8 @@ public void EscapedODBC()
 		[Test]
 		public void DoubleAliasing()
 		{
-			if (Dialect is MySQLDialect) return;
-			if (Dialect is FirebirdDialect) return; // See comment below
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-select, used by Map formula in B (C1 and C2) mapping");
 
 			ISession session = OpenSession();
 
@@ -364,7 +364,6 @@ public void DoubleAliasing()
 			Assert.IsNotNull(list);
 
 			Assert.AreEqual(2, list.Count);
-			// On Firebird the list has 4 elements, I don't understand why.
 
 			session.Delete("from A");
 			session.Flush();
@@ -582,7 +581,8 @@ public void FindBySQLDiscriminatorSameSession()
 		[Test]
 		public void FindBySQLDiscriminatedDiffSessions()
 		{
-			if (Dialect is MySQLDialect) return;
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-select, used by Map formula in B (C1 and C2) mapping");
 
 			ISession session = OpenSession();
 			A savedA = new A();

src/NHibernate.Test/Linq/ByMethod/AnyTests.cs

@@ -41,6 +41,9 @@ public void ManyToManyAny()
 		[Test(Description = "NH-2654")]
 		public void AnyWithCount()
 		{
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-selects");
+
 			var result = db.Orders
 				.Any(p => p.OrderLines.Count == 0);
 

src/NHibernate.Test/Linq/ByMethod/CountTests.cs

@@ -16,6 +16,8 @@ protected override void Configure(Configuration configuration)
 		[Test]
 		public void CountDistinctProperty_ReturnsNumberOfDistinctEntriesForThatProperty()
 		{
+			if (!TestDialect.SupportsCountDistinct)
+				Assert.Ignore("Dialect does not support count distinct");
 			//NH-2722
 			var result = db.Orders
 				.Select(x => x.ShippingDate)
@@ -49,6 +51,8 @@ public void Count_ReturnsNumberOfRecords()
 		[Test]
 		public void LongCountDistinctProperty_ReturnsNumberOfDistinctEntriesForThatProperty()
 		{
+			if (!TestDialect.SupportsCountDistinct)
+				Assert.Ignore("Dialect does not support count distinct");
 			//NH-2722
 			var result = db.Orders
 				.Select(x => x.ShippingDate)

src/NHibernate.Test/Linq/ByMethod/GroupByTests.cs

@@ -88,6 +88,9 @@ public void SingleKeyGroupAndOrderByKey()
 		[Test]
 		public void SingleKeyGroupAndOrderByKeyAggregateProjection()
 		{
+			if (!TestDialect.SupportsOrderByAggregate)
+				Assert.Ignore("Dialect does not support ordering by an aggregation");
+
 			//NH-2452
 			var result = db.Products
 				.GroupBy(i => i.UnitPrice)
@@ -106,6 +109,9 @@ public void SingleKeyGroupAndOrderByKeyAggregateProjection()
 		[Test]
 		public void SingleKeyPropertyGroupAndOrderByProjectedCount()
 		{
+			if (!TestDialect.SupportsOrderByAggregate)
+				Assert.Ignore("Dialect does not support ordering by an aggregation");
+
 			// NH-2560
 
 			var orderCounts = db.Orders
@@ -126,6 +132,9 @@ public void SingleKeyPropertyGroupAndOrderByProjectedCount()
 		[Test]
 		public void SingleKeyPropertyGroupAndOrderByCountBeforeProjection()
 		{
+			if (!TestDialect.SupportsOrderByAggregate)
+				Assert.Ignore("Dialect does not support ordering by an aggregation");
+
 			// NH-3026, variation of NH-2560.
 			// This is a variation of SingleKeyPropertyGroupAndOrderByProjectedCount()
 			// that puts the ordering expression inside the OrderBy, without first
@@ -216,6 +225,8 @@ public void SingleKeyPropertyGroupByEntityAndSelectEntity()
 		[Test]
 		public void SingleKeyGroupAndOrderByNonKeyAggregateProjection()
 		{
+			if (!TestDialect.SupportsOrderByAggregate)
+				Assert.Ignore("Dialect does not support ordering by an aggregation");
 			//NH-2452
 			var result = db.Products
 				.GroupBy(p => p.UnitPrice)
@@ -448,6 +459,9 @@ public void FilteredByCountWithPredicate()
 		[Test]
 		public void FilteredByCountFromSubQuery()
 		{
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-selects");
+
 			//Not really an aggregate filter, but included to ensure that this kind of query still works
 			var result = db.Products
 				.GroupBy(x => x.Supplier.CompanyName)
@@ -498,6 +512,9 @@ public void FilteredByKeyAndProjectedWithAggregatePredicates()
 		[Test]
 		public void ProjectingWithSubQueriesFilteredByTheAggregateKey()
 		{
+			if (!Dialect.SupportsScalarSubSelects)
+				Assert.Ignore("Dialect does not support scalar sub-selects");
+
 			var result=db.Products.GroupBy(x => x.Supplier.Address.Country)
 			 .OrderBy(x=>x.Key)
 			 .Select(x => new { x.Key, MaxFreight = db.Orders.Where(y => y.ShippingAddress.Country == x.Key).Max(y => y.Freight), FirstOrder = db.Orders.Where(o => o.Employee.FirstName.StartsWith("A")).OrderBy(o => o.OrderId).Select(y => y.OrderId).First() })