fixup! Fix transaction leak

Author: fredericDelaporte

src/NHibernate.Test/Async/TransactionTest/TransactionFixture.cs

@@ -100,8 +100,7 @@ public async Task WasCommittedOrRolledBackAsync()
 					Assert.IsFalse(s.GetCurrentTransaction().WasRolledBack);
 					await (t.CommitAsync());
 
-					// ISession.GetCurrentTransaction() does not return a new transaction
-					// if the previous one is completed.
+					// ISession.GetCurrentTransaction() returns null if the transaction is completed.
 					Assert.IsNull(s.GetCurrentTransaction());
 
 					Assert.IsTrue(t.WasCommitted);
@@ -113,8 +112,7 @@ public async Task WasCommittedOrRolledBackAsync()
 				{
 					await (t.RollbackAsync());
 
-					// ISession.GetCurrentTransaction() does not return a new transaction
-					// if the previous one is completed.
+					// ISession.GetCurrentTransaction() returns null if the transaction is completed.
 					Assert.IsNull(s.GetCurrentTransaction());
 
 					Assert.IsTrue(t.WasRolledBack);

src/NHibernate.Test/TransactionTest/TransactionFixture.cs

@@ -102,8 +102,7 @@ public void WasCommittedOrRolledBack()
 					Assert.IsFalse(s.GetCurrentTransaction().WasRolledBack);
 					t.Commit();
 
-					// ISession.GetCurrentTransaction() does not return a new transaction
-					// if the previous one is completed.
+					// ISession.GetCurrentTransaction() returns null if the transaction is completed.
 					Assert.IsNull(s.GetCurrentTransaction());
 
 					Assert.IsTrue(t.WasCommitted);
@@ -115,8 +114,7 @@ public void WasCommittedOrRolledBack()
 				{
 					t.Rollback();
 
-					// ISession.GetCurrentTransaction() does not return a new transaction
-					// if the previous one is completed.
+					// ISession.GetCurrentTransaction() returns null if the transaction is completed.
 					Assert.IsNull(s.GetCurrentTransaction());
 
 					Assert.IsTrue(t.WasRolledBack);

src/NHibernate/AdoNet/ConnectionManager.cs

@@ -418,7 +418,7 @@ public ITransaction Transaction
 		}
 
 		/// <summary>
-		/// The current transaction if any, else <see langword="null" />.
+		/// The current transaction if any is ongoing, else <see langword="null" />.
 		/// </summary>
 		public ITransaction CurrentTransaction => _transaction;
 

src/NHibernate/ISession.cs

@@ -14,7 +14,7 @@
 
 namespace NHibernate
 {
-	// 6.0 TODO: Convert to interface methods
+	// 6.0 TODO: Convert most of these extensions to interface methods
 	public static class SessionExtensions
 	{
 		/// <summary>
@@ -40,9 +40,9 @@ public static IQueryBatch CreateQueryBatch(this ISession session)
 			return ReflectHelper.CastOrThrow<AbstractSessionImpl>(session, "query batch").CreateQueryBatch();
 		}
 
-		// 6.0 TODO: add as property on ISession, obsolete this.
+		// 6.0 TODO: consider if it should be added as a property on ISession then obsolete this, or if it should stay here as an extension method.
 		/// <summary>
-		/// Get the current transaction if any, else <see langword="null" />.
+		/// Get the current transaction if any is ongoing, else <see langword="null" />.
 		/// </summary>
 		/// <param name="session">The session.</param>
 		/// <returns>The current transaction or <see langword="null" />..</returns>

src/NHibernate/IStatelessSession.cs

@@ -10,7 +10,7 @@
 
 namespace NHibernate
 {
-	// 6.0 TODO: Convert to interface methods
+	// 6.0 TODO: Convert most of these extensions to interface methods
 	public static class StatelessSessionExtensions
 	{
 		/// <summary>
@@ -22,6 +22,15 @@ public static IQueryBatch CreateQueryBatch(this IStatelessSession session)
 		{
 			return ReflectHelper.CastOrThrow<AbstractSessionImpl>(session, "query batch").CreateQueryBatch();
 		}
+
+		// 6.0 TODO: consider if it should be added as a property on IStatelessSession then obsolete this, or if it should stay here as an extension method.
+		/// <summary>
+		/// Get the current transaction if any is ongoing, else <see langword="null" />.
+		/// </summary>
+		/// <param name="session">The session.</param>
+		/// <returns>The current transaction or <see langword="null" />..</returns>
+		public static ITransaction GetCurrentTransaction(this IStatelessSession session)
+			=> session.GetSessionImplementation().ConnectionManager.CurrentTransaction;
 	}
 
 	/// <summary>
@@ -57,11 +66,6 @@ public partial interface IStatelessSession : IDisposable
 		// Since v5.3
 		[Obsolete("Use CurrentTransaction instead, and check for null.")]
 		ITransaction Transaction { get; }
-
-		/// <summary>
-		/// The current transaction if any, else <see langword="null" />.
-		/// </summary>
-		ITransaction CurrentTransaction { get; }
 
 		/// <summary>
 		/// Is the <c>IStatelessSession</c> still open?

src/NHibernate/Impl/AbstractSessionImpl.cs

@@ -41,11 +41,6 @@ public abstract partial class AbstractSessionImpl : ISessionImplementor
 		[Obsolete("Use CurrentTransaction instead, and check for null.")]
 		public ITransaction Transaction => ConnectionManager.Transaction;
 
-		/// <summary>
-		/// The current transaction if any, else <see langword="null" />.
-		/// </summary>
-		public ITransaction CurrentTransaction => ConnectionManager.CurrentTransaction;
-
 		protected bool IsTransactionCoordinatorShared { get; }
 
 		public ITransactionContext TransactionContext