Skip to content

Commit 2cedbd5

Browse files
committed
Skip tests for MySql
1 parent 43fefb9 commit 2cedbd5

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

src/NHibernate.Test/NHSpecificTest/GH3334/Fixture.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ public void OneTimeTearDown()
4444
transaction.Commit();
4545
}
4646

47+
protected override bool AppliesTo(Dialect.Dialect dialect)
48+
{
49+
return TestDialect.SupportsCorrelatedColumnsInSubselectJoin;
50+
}
51+
4752
public class TestCaseItem
4853
{
4954
public string Name { get; }

src/NHibernate.Test/TestDialect.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,5 +203,10 @@ public bool SupportsSqlType(SqlType sqlType)
203203
/// Returns true if you can cancel a query.
204204
/// </summary>
205205
public virtual bool SupportsCancelQuery => true;
206+
207+
/// <summary>
208+
/// Some databases (MySql) don't support using main table aliases in subquery inside join ON clause
209+
/// </summary>
210+
public virtual bool SupportsCorrelatedColumnsInSubselectJoin => true;
206211
}
207212
}

src/NHibernate.Test/TestDialects/MySQL5TestDialect.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,12 @@ public MySQL5TestDialect(Dialect.Dialect dialect)
1414
/// This behaviour is documented at: http://dev.mysql.com/doc/refman/5.6/en/update.html
1515
/// </summary>
1616
public override bool SupportsModifyAndSelectSameTable => false;
17+
18+
/// <summary>
19+
/// A correlated column can be present only in the subquery's WHERE clause (and not in the SELECT list,
20+
/// a JOIN or ORDER BY clause, a GROUP BY list, or a HAVING clause). Nor can there be any correlated column inside a derived table in the subquery's FROM list.
21+
/// See https://dev.mysql.com/doc/refman/8.0/en/correlated-subqueries.html
22+
/// </summary>
23+
public override bool SupportsCorrelatedColumnsInSubselectJoin => false;
1724
}
1825
}

0 commit comments

Comments
 (0)