Fix NH-2840 - SetFirstResult and SetMaxResults do not work correctly on Oracle (ODP.NET)

Fixes the following tests on Oracle:

NHibernate.Test.Criteria.CriteriaQueryTest.SimplePagination
NHibernate.Test.Criteria.Lambda.IntegrationFixture.RowCount
NHibernate.Test.Legacy.FooBarTest.Limit
NHibernate.Test.Legacy.FooBarTest.PSCache
NHibernate.Test.Legacy.SQLFunctionsTest.SQLFunctions
NHibernate.Test.NHSpecificTest.NH1533.Fixture.Can_query_using_two_orderby_and_limit_altogether
NHibernate.Test.NHSpecificTest.NH2251.Fixture.FuturePagedHql
NHibernate.Test.NHSpecificTest.NH2251.Fixture.HqlWithOffsetAndLimit
NHibernate.Test.NHSpecificTest.NH2251.Fixture.MultiplePagingParametersInSingleQuery
NHibernate.Test.Pagination.PaginationFixture.PagTest
NHibernate.Test.QueryTest.DetachedQueryFixture.ExecutableQuery

Author: FlukeFan

src/NHibernate/Param/QueryTakeParameterSpecification.cs

@@ -1,87 +1,87 @@
-using System;
-using System.Collections.Generic;
-using System.Data;
-using System.Linq;
-using NHibernate.Engine;
-using NHibernate.SqlCommand;
-using NHibernate.Type;
-
-namespace NHibernate.Param
-{
-	/// <summary>
-	/// Autogenerated parameter for <see cref="IQuery.SetMaxResults"/>.
-	/// </summary>
-	public class QueryTakeParameterSpecification : IParameterSpecification
-	{
-		// NOTE: don't use this for HQL take clause
-		private readonly string[] idTrack;
-		private readonly string limitParametersNameForThisQuery = "<nhtake" + Guid.NewGuid().ToString("N"); // NH_note: to avoid conflicts using MultiQuery/Future
-		private readonly IType type = NHibernateUtil.Int32;
-
-		public QueryTakeParameterSpecification()
-		{
-			idTrack = new[] { limitParametersNameForThisQuery };
-		}
-
-		#region IParameterSpecification Members
-
-		public void Bind(IDbCommand command, IList<Parameter> sqlQueryParametersList, QueryParameters queryParameters, ISessionImplementor session)
-		{
-			Bind(command, sqlQueryParametersList, 0, sqlQueryParametersList, queryParameters, session);
-		}
-
-		public void Bind(IDbCommand command, IList<Parameter> multiSqlQueryParametersList, int singleSqlParametersOffset, IList<Parameter> sqlQueryParametersList, QueryParameters queryParameters, ISessionImplementor session)
-		{
-			// The QueryTakeParameterSpecification is unique so we can use multiSqlQueryParametersList
-			var effectiveParameterLocations = multiSqlQueryParametersList.GetEffectiveParameterLocations(limitParametersNameForThisQuery).ToArray();
-			if (effectiveParameterLocations.Any())
-			{
-				// if the dialect does not support variable limits the parameter may was removed
-				int value = queryParameters.RowSelection.MaxRows;
-				int position = effectiveParameterLocations.Single();
-				type.NullSafeSet(command, value, position, session);
-			}
-		}
-
-		public IType ExpectedType
-		{
-			get { return type; }
-			set { throw new InvalidOperationException(); }
-		}
-
-		public string RenderDisplayInfo()
-		{
-			return "query-take";
-		}
-
-		public IEnumerable<string> GetIdsForBackTrack(IMapping sessionFactory)
-		{
-			return idTrack;
-		}
-
-		#endregion
-
-		public override bool Equals(object obj)
-		{
-			return Equals(obj as QueryTakeParameterSpecification);
-		}
-
-		public bool Equals(QueryTakeParameterSpecification other)
-		{
-			if (ReferenceEquals(null, other))
-			{
-				return false;
-			}
-			if (ReferenceEquals(this, other))
-			{
-				return true;
-			}
-			return Equals(other.limitParametersNameForThisQuery, limitParametersNameForThisQuery);
-		}
-
-		public override int GetHashCode()
-		{
-			return limitParametersNameForThisQuery.GetHashCode();
-		}
-	}
+using System;
+using System.Collections.Generic;
+using System.Data;
+using System.Linq;
+using NHibernate.Engine;
+using NHibernate.SqlCommand;
+using NHibernate.Type;
+
+namespace NHibernate.Param
+{
+	/// <summary>
+	/// Autogenerated parameter for <see cref="IQuery.SetMaxResults"/>.
+	/// </summary>
+	public class QueryTakeParameterSpecification : IParameterSpecification
+	{
+		// NOTE: don't use this for HQL take clause
+		private readonly string[] idTrack;
+		private readonly string limitParametersNameForThisQuery = "<nhtake" + Guid.NewGuid().ToString("N"); // NH_note: to avoid conflicts using MultiQuery/Future
+		private readonly IType type = NHibernateUtil.Int32;
+
+		public QueryTakeParameterSpecification()
+		{
+			idTrack = new[] { limitParametersNameForThisQuery };
+		}
+
+		#region IParameterSpecification Members
+
+		public void Bind(IDbCommand command, IList<Parameter> sqlQueryParametersList, QueryParameters queryParameters, ISessionImplementor session)
+		{
+			Bind(command, sqlQueryParametersList, 0, sqlQueryParametersList, queryParameters, session);
+		}
+
+		public void Bind(IDbCommand command, IList<Parameter> multiSqlQueryParametersList, int singleSqlParametersOffset, IList<Parameter> sqlQueryParametersList, QueryParameters queryParameters, ISessionImplementor session)
+		{
+			// The QueryTakeParameterSpecification is unique so we can use multiSqlQueryParametersList
+			var effectiveParameterLocations = multiSqlQueryParametersList.GetEffectiveParameterLocations(limitParametersNameForThisQuery).ToArray();
+			if (effectiveParameterLocations.Any())
+			{
+				// if the dialect does not support variable limits the parameter may was removed
+				int value = Loader.Loader.GetLimitUsingDialect(queryParameters.RowSelection, session.Factory.Dialect) ?? queryParameters.RowSelection.MaxRows;
+				int position = effectiveParameterLocations.Single();
+				type.NullSafeSet(command, value, position, session);
+			}
+		}
+
+		public IType ExpectedType
+		{
+			get { return type; }
+			set { throw new InvalidOperationException(); }
+		}
+
+		public string RenderDisplayInfo()
+		{
+			return "query-take";
+		}
+
+		public IEnumerable<string> GetIdsForBackTrack(IMapping sessionFactory)
+		{
+			return idTrack;
+		}
+
+		#endregion
+
+		public override bool Equals(object obj)
+		{
+			return Equals(obj as QueryTakeParameterSpecification);
+		}
+
+		public bool Equals(QueryTakeParameterSpecification other)
+		{
+			if (ReferenceEquals(null, other))
+			{
+				return false;
+			}
+			if (ReferenceEquals(this, other))
+			{
+				return true;
+			}
+			return Equals(other.limitParametersNameForThisQuery, limitParametersNameForThisQuery);
+		}
+
+		public override int GetHashCode()
+		{
+			return limitParametersNameForThisQuery.GetHashCode();
+		}
+	}
 }