When saving a byte array, throw an exception if the db parameter's size is

set to a value smaller than the length of the array, to prevent silent
truncation (NH-3121).

Author: oskarb

src/NHibernate.Test/DialectTest/MsSql2005DialectFixture.cs

@@ -103,6 +103,9 @@ public void NH2809()
 			t = d.GetTypeName(new BinarySqlType(), SqlClientDriver.MaxSizeForLengthLimitedBinary - 1, 0, 0);
 			Assert.That(t, Is.EqualTo(String.Format("VARBINARY({0})", SqlClientDriver.MaxSizeForLengthLimitedBinary - 1)));
 
+			t = d.GetTypeName(new BinarySqlType(), SqlClientDriver.MaxSizeForLengthLimitedBinary, 0, 0);
+			Assert.That(t, Is.EqualTo(String.Format("VARBINARY({0})", SqlClientDriver.MaxSizeForLengthLimitedBinary)));
+
 			t = d.GetTypeName(new BinarySqlType(), SqlClientDriver.MaxSizeForLengthLimitedBinary + 1, 0, 0);
 			Assert.That(t, Is.EqualTo("VARBINARY(MAX)"));
 		}

src/NHibernate.Test/NHSpecificTest/NH3121/Fixture.cs

@@ -0,0 +1,90 @@
+using System;
+using System.Drawing;
+using System.Linq;
+using System.Reflection;
+using NHibernate.Dialect;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH3121
+{
+	[TestFixture]
+	public class Fixture : BugTestCase
+	{
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			return dialect is MsSql2000Dialect; // All MS dialects.
+		}
+
+		// Some notes:
+		// Mappings for all three properties use either unspecified length (defaulting to 8000 bytes)
+		// or a length specified to a value smaller than 8001 bytes. This is since for larger values
+		// the driver will increase the parameter size to int.MaxValue/2.
+
+		[Test]
+		public void ShouldThrowWhenByteArrayTooLong()
+		{
+			const int reportSize = 17158;
+			var random = new Random();
+
+			var reportImage = new Byte[reportSize];
+			random.NextBytes(reportImage);
+
+			var report = new Report { UnsizedArray = reportImage };
+
+			var ex = Assert.Throws<PropertyValueException>(() => PersistReport(report));
+
+			Assert.That(ex.Message, Is.StringContaining("Report.UnsizedArray"));
+			Assert.That(ex.InnerException, Is.TypeOf<HibernateException>());
+			Assert.That(ex.InnerException.Message,
+						Is.EqualTo("The length of the byte[] value exceeds the length configured in the mapping/parameter."));
+		}
+
+
+		[Test]
+		public void ShouldThrowWhenImageTooLarge()
+		{
+			Assembly assembly = Assembly.Load(MappingsAssembly);
+			var stream = assembly.GetManifestResourceStream("NHibernate.Test.NHSpecificTest.NH2484.food-photo.jpg");
+			var image = Bitmap.FromStream(stream);
+
+			var report = new Report { Image = image };
+
+			var ex = Assert.Throws<PropertyValueException>(() => PersistReport(report));
+
+			Assert.That(ex.Message, Is.StringContaining("Report.Image"));
+			Assert.That(ex.InnerException, Is.TypeOf<HibernateException>());
+			Assert.That(ex.InnerException.Message,
+						Is.EqualTo("The length of the byte[] value exceeds the length configured in the mapping/parameter."));
+		}
+
+
+		[Test]
+		public void ShouldThrowWhenImageAsISerializableTooLarge()
+		{
+			Assembly assembly = Assembly.Load(MappingsAssembly);
+			var stream = assembly.GetManifestResourceStream("NHibernate.Test.NHSpecificTest.NH2484.food-photo.jpg");
+			var image = Bitmap.FromStream(stream);
+
+			var report = new Report { SerializableImage = image };
+
+			var ex = Assert.Throws<PropertyValueException>(() => PersistReport(report));
+
+			Assert.That(ex.Message, Is.StringContaining("Report.SerializableImage"));
+			Assert.That(ex.InnerException, Is.TypeOf<HibernateException>());
+			Assert.That(ex.InnerException.Message,
+						Is.EqualTo("The length of the byte[] value exceeds the length configured in the mapping/parameter."));
+		}
+
+
+		private void PersistReport(Report report)
+		{
+			using (var session = OpenSession())
+			using (session.BeginTransaction())
+			{
+				session.Save(report);
+				session.Flush();
+				// No commit to avoid DB pollution (test success means we should throw and never insert anyway).
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH3121/Mappings.hbm.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping
+	xmlns="urn:nhibernate-mapping-2.2"
+	assembly="NHibernate.Test"
+	namespace="NHibernate.Test.NHSpecificTest.NH3121">
+
+	<class name="Report">
+		
+		<id name="Id">
+			<generator class="guid" />
+		</id>
+
+		<property name="UnsizedArray" />
+			
+		<property name="Image" type="System.Drawing.Image, System.Drawing, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
+			<column name="Image" length="7000" not-null="false" />
+		</property>
+
+		<property name="SerializableImage" type="Serializable(7000)">
+			<column name="SerializableImage" not-null="false" />
+		</property>
+		
+	</class>
+
+</hibernate-mapping>

src/NHibernate.Test/NHSpecificTest/NH3121/Report.cs

@@ -0,0 +1,17 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.Serialization;
+using System.Text;
+
+namespace NHibernate.Test.NHSpecificTest.NH3121
+{
+	public class Report
+	{
+		public virtual Guid Id { get; set; }
+
+		public virtual Byte[] UnsizedArray { get; set; }
+		public virtual System.Drawing.Image Image { get; set; }
+		public virtual ISerializable SerializableImage { get; set; }
+	}
+}

src/NHibernate.Test/NHibernate.Test.csproj

@@ -967,6 +967,8 @@
     <Compile Include="NHSpecificTest\NH3004\TestSqlClientDriver.cs" />
     <Compile Include="NHSpecificTest\NH3074\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH3074\Model.cs" />
+    <Compile Include="NHSpecificTest\NH3121\Fixture.cs" />
+    <Compile Include="NHSpecificTest\NH3121\Report.cs" />
     <Compile Include="NHSpecificTest\NH3126\InvalidCastTestCase.cs" />
     <Compile Include="NHSpecificTest\NH3126\Item.cs" />
     <Compile Include="NHSpecificTest\NH3126\Property.cs" />
@@ -2834,6 +2836,7 @@
     <EmbeddedResource Include="NHSpecificTest\NH1291AnonExample\Mappings.hbm.xml" />
   </ItemGroup>
   <ItemGroup>
+    <EmbeddedResource Include="NHSpecificTest\NH3121\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH2789\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3142\Mappings.hbm.xml" />
     <EmbeddedResource Include="NHSpecificTest\NH3153\SchemaInClass.hbm.xml" />

src/NHibernate/Type/AbstractBinaryType.cs

@@ -76,7 +76,15 @@ public virtual int Compare(object x, object y)
 		public override void Set(IDbCommand cmd, object value, int index)
 		{
 			byte[] internalValue = ToInternalFormat(value);
-			((IDataParameter)cmd.Parameters[index]).Value = internalValue;
+
+			var parameter = (IDbDataParameter)cmd.Parameters[index];
+
+			// set the parameter value before the size check, since ODBC changes the size automatically
+			parameter.Value = internalValue;
+
+			// Avoid silent truncation which happens in ADO.NET if the parameter size is set.
+			if (parameter.Size > 0 && internalValue.Length > parameter.Size)
+				throw new HibernateException("The length of the byte[] value exceeds the length configured in the mapping/parameter.");
 		}
 
 		public override object Get(IDataReader rs, int index)